Re: [Qemu-devel] [PATCH 2/4] hw/virtio: Factorize virtio-mmio headers

2019-07-02 Thread Michael S. Tsirkin
On Tue, Jul 02, 2019 at 10:19:10AM +0200, Gerd Hoffmann wrote: > > > > I am not sure we want a new machine with 0.X mmio devices. > > > > Especially considering that virtio-mmio does not have support for > > > > transitional devices. > > > > > > What are the practical implications of that? > > >

Re: [Qemu-devel] [PATCH 2/4] hw/virtio: Factorize virtio-mmio headers

2019-07-02 Thread Gerd Hoffmann
> > > I am not sure we want a new machine with 0.X mmio devices. > > > Especially considering that virtio-mmio does not have support for > > > transitional devices. > > > > What are the practical implications of that? > > On the plus side, this means we don't need to maintain a bunch of hacks > f

Re: [Qemu-devel] [PATCH 2/4] hw/virtio: Factorize virtio-mmio headers

2019-06-30 Thread Michael S. Tsirkin
On Fri, Jun 28, 2019 at 10:50:47PM +0200, Sergio Lopez wrote: > > Michael S. Tsirkin writes: > > > On Fri, Jun 28, 2019 at 01:53:47PM +0200, Sergio Lopez wrote: > >> Put QOM and main struct definition in a separate header file, so it > >> can be accesed from other components. > >> > >> This is

Re: [Qemu-devel] [PATCH 2/4] hw/virtio: Factorize virtio-mmio headers

2019-06-28 Thread Sergio Lopez
Michael S. Tsirkin writes: > On Fri, Jun 28, 2019 at 01:53:47PM +0200, Sergio Lopez wrote: >> Put QOM and main struct definition in a separate header file, so it >> can be accesed from other components. >> >> This is needed for the microvm machine type implementation. >> >> Signed-off-by: Serg

Re: [Qemu-devel] [PATCH 2/4] hw/virtio: Factorize virtio-mmio headers

2019-06-28 Thread Michael S. Tsirkin
On Fri, Jun 28, 2019 at 01:53:47PM +0200, Sergio Lopez wrote: > Put QOM and main struct definition in a separate header file, so it > can be accesed from other components. > > This is needed for the microvm machine type implementation. > > Signed-off-by: Sergio Lopez If you are going to product

[Qemu-devel] [PATCH 2/4] hw/virtio: Factorize virtio-mmio headers

2019-06-28 Thread Sergio Lopez
Put QOM and main struct definition in a separate header file, so it can be accesed from other components. This is needed for the microvm machine type implementation. Signed-off-by: Sergio Lopez --- hw/virtio/virtio-mmio.c | 35 +--- hw/virtio/virtio-mmio.h | 60 +