Re: [Qemu-devel] [PATCH 2/4] exec: rename resolve_subpage

2017-05-15 Thread Peter Xu
On Mon, May 15, 2017 at 11:03:49AM +0200, Paolo Bonzini wrote: > > > On 15/05/2017 10:50, Peter Xu wrote: > > It is not easy for people to know "what this parameter does" before > > knowing "what is subpage". Let's use "is_mmio" to make it easier to > > understand. > > > > Signed-off-by: Peter X

Re: [Qemu-devel] [PATCH 2/4] exec: rename resolve_subpage

2017-05-15 Thread Paolo Bonzini
On 15/05/2017 10:50, Peter Xu wrote: > It is not easy for people to know "what this parameter does" before > knowing "what is subpage". Let's use "is_mmio" to make it easier to > understand. > > Signed-off-by: Peter Xu Maybe invert the direction and call it for_iotlb? Paolo > --- > exec.c |

[Qemu-devel] [PATCH 2/4] exec: rename resolve_subpage

2017-05-15 Thread Peter Xu
It is not easy for people to know "what this parameter does" before knowing "what is subpage". Let's use "is_mmio" to make it easier to understand. Signed-off-by: Peter Xu --- exec.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/exec.c b/exec.c index 1d76c63..0adae9