Re: [Qemu-devel] [PATCH 2/3] tests/libqtest: Allow to set expected exit status

2019-08-27 Thread Yury Kotov
27.08.2019, 17:04, "Eric Blake" : > On 8/27/19 7:02 AM, Yury Kotov wrote: > > In the subject: 'Allow to $verb' is not idiomatic; either 'Allow > $subject to $verb' or 'Allow ${verb}ing' sound better. In this case, > I'd go with: > > tests/libqtest: Allow setting expected exit status > Ok, thanks.

Re: [Qemu-devel] [PATCH 2/3] tests/libqtest: Allow to set expected exit status

2019-08-27 Thread Yury Kotov
27.08.2019, 16:53, "Marc-André Lureau" : > Hi > > On Tue, Aug 27, 2019 at 4:09 PM Yury Kotov wrote: >>  Add qtest_set_expected_status function to set expected exit status of >>  child process. By default expected exit status is 0. >> >>  Signed-off-by: Yury Kotov >>  --- >>   tests/libqtest.c | 1

Re: [Qemu-devel] [PATCH 2/3] tests/libqtest: Allow to set expected exit status

2019-08-27 Thread Eric Blake
On 8/27/19 7:02 AM, Yury Kotov wrote: In the subject: 'Allow to $verb' is not idiomatic; either 'Allow $subject to $verb' or 'Allow ${verb}ing' sound better. In this case, I'd go with: tests/libqtest: Allow setting expected exit status > Add qtest_set_expected_status function to set expected ex

Re: [Qemu-devel] [PATCH 2/3] tests/libqtest: Allow to set expected exit status

2019-08-27 Thread Marc-André Lureau
Hi On Tue, Aug 27, 2019 at 4:09 PM Yury Kotov wrote: > > Add qtest_set_expected_status function to set expected exit status of > child process. By default expected exit status is 0. > > Signed-off-by: Yury Kotov > --- > tests/libqtest.c | 14 +++--- > tests/libqtest.h | 9 + >

[Qemu-devel] [PATCH 2/3] tests/libqtest: Allow to set expected exit status

2019-08-27 Thread Yury Kotov
Add qtest_set_expected_status function to set expected exit status of child process. By default expected exit status is 0. Signed-off-by: Yury Kotov --- tests/libqtest.c | 14 +++--- tests/libqtest.h | 9 + 2 files changed, 20 insertions(+), 3 deletions(-) diff --git a/tests/li