Re: [Qemu-devel] [PATCH 2/3] target-i386: Add Intel HAX files

2016-11-09 Thread Vincent Palatin
On Wed, Nov 9, 2016 at 1:30 PM, Stefan Hajnoczi wrote: > On Tue, Nov 08, 2016 at 04:39:28PM +0100, Vincent Palatin wrote: > > Please run scripts/checkpatch.pl to verify that the code follows the > QEMU coding style. My original plan was to import those files unmodified but this ship has probably

Re: [Qemu-devel] [PATCH 2/3] target-i386: Add Intel HAX files

2016-11-09 Thread Vincent Palatin
On Tue, Nov 8, 2016 at 6:46 PM, Paolo Bonzini wrote: > > > On 08/11/2016 16:39, Vincent Palatin wrote: >> +/* need tcg for non-UG platform in real mode */ >> +if (!hax_ug_platform()) >> + tcg_exec_init(tcg_tb_size * 1024 * 1024); >> + > > Oh, it does support unrestricted

Re: [Qemu-devel] [PATCH 2/3] target-i386: Add Intel HAX files

2016-11-09 Thread Stefan Hajnoczi
On Tue, Nov 08, 2016 at 04:39:28PM +0100, Vincent Palatin wrote: Please run scripts/checkpatch.pl to verify that the code follows the QEMU coding style. > +hax_fd hax_host_open_vcpu(int vmid, int vcpuid) > +{ > +char *devfs_path = NULL; > +hax_fd fd; > + > +devfs_path = hax_vcpu_devfs

Re: [Qemu-devel] [PATCH 2/3] target-i386: Add Intel HAX files

2016-11-08 Thread Vincent Palatin
On Tue, Nov 8, 2016 at 6:46 PM, Paolo Bonzini wrote: > > > On 08/11/2016 16:39, Vincent Palatin wrote: >> +/* need tcg for non-UG platform in real mode */ >> +if (!hax_ug_platform()) >> + tcg_exec_init(tcg_tb_size * 1024 * 1024); >> + > > Oh, it does support unrestricted

Re: [Qemu-devel] [PATCH 2/3] target-i386: Add Intel HAX files

2016-11-08 Thread Paolo Bonzini
On 08/11/2016 16:39, Vincent Palatin wrote: > +/* need tcg for non-UG platform in real mode */ > +if (!hax_ug_platform()) > + tcg_exec_init(tcg_tb_size * 1024 * 1024); > + Oh, it does support unrestricted guest, and in fact without unrestricted guest you don't even have

[Qemu-devel] [PATCH 2/3] target-i386: Add Intel HAX files

2016-11-08 Thread Vincent Palatin
That's a forward port of the core HAX interface code mostly unmodified from emu-2.2-release branch in the external/qemu-android repository as used by the Android emulator. The original commit was "target-i386: Add Intel HAX to android emulator" saying: """ Backport of 2b3098ff27bab079caab9b46b58