Re: [Qemu-devel] [PATCH 2/3] target/ppc: convert to DisasContextBase

2018-02-15 Thread Richard Henderson
On 02/14/2018 07:14 PM, Emilio G. Cota wrote: > A couple of notes: > > - removed ctx->nip in favour of base->pc_next. Yes, it is annoying, > but didn't want to waste its 4 bytes. > > - ctx->singlestep_enabled does a lot more than > base.singlestep_enabled; this confused me at first. > > Sign

[Qemu-devel] [PATCH 2/3] target/ppc: convert to DisasContextBase

2018-02-14 Thread Emilio G. Cota
A couple of notes: - removed ctx->nip in favour of base->pc_next. Yes, it is annoying, but didn't want to waste its 4 bytes. - ctx->singlestep_enabled does a lot more than base.singlestep_enabled; this confused me at first. Signed-off-by: Emilio G. Cota --- target/ppc/translate.c