Re: [Qemu-devel] [PATCH 2/3] target/arm/kvm: split pmu init from creation

2017-07-18 Thread Andrew Jones
On Tue, Jul 18, 2017 at 01:44:34PM +0100, Peter Maydell wrote: > On 18 July 2017 at 13:38, Andrew Jones wrote: > > On Mon, Jul 10, 2017 at 04:27:35PM +0100, Peter Maydell wrote: > >> On 1 July 2017 at 17:47, Andrew Jones wrote: > >> > When adding a PMU with a userspace irqchip we only do the INIT

Re: [Qemu-devel] [PATCH 2/3] target/arm/kvm: split pmu init from creation

2017-07-18 Thread Peter Maydell
On 18 July 2017 at 13:38, Andrew Jones wrote: > On Mon, Jul 10, 2017 at 04:27:35PM +0100, Peter Maydell wrote: >> On 1 July 2017 at 17:47, Andrew Jones wrote: >> > When adding a PMU with a userspace irqchip we only do the INIT >> > stage of the device creation. >> >> Can you explain why? My assum

Re: [Qemu-devel] [PATCH 2/3] target/arm/kvm: split pmu init from creation

2017-07-18 Thread Andrew Jones
On Mon, Jul 10, 2017 at 04:27:35PM +0100, Peter Maydell wrote: > On 1 July 2017 at 17:47, Andrew Jones wrote: > > When adding a PMU with a userspace irqchip we only do the INIT > > stage of the device creation. > > Can you explain why? My assumption would be that either > (a) we don't need the ke

Re: [Qemu-devel] [PATCH 2/3] target/arm/kvm: split pmu init from creation

2017-07-10 Thread Peter Maydell
On 1 July 2017 at 17:47, Andrew Jones wrote: > When adding a PMU with a userspace irqchip we only do the INIT > stage of the device creation. Can you explain why? My assumption would be that either (a) we don't need the kernel's PMU, in which case don't create it at all, or (b) we do need the ker

[Qemu-devel] [PATCH 2/3] target/arm/kvm: split pmu init from creation

2017-07-01 Thread Andrew Jones
When adding a PMU with a userspace irqchip we only do the INIT stage of the device creation. Signed-off-by: Andrew Jones --- hw/arm/virt.c| 10 -- target/arm/kvm32.c | 6 ++ target/arm/kvm64.c | 52 +--- target/arm/kvm_arm.