Re: [Qemu-devel] [PATCH 2/3] ramfb enhancement

2019-05-10 Thread Gerd Hoffmann
On Fri, May 10, 2019 at 02:41:36PM +0800, Hou Qiming wrote: > > Only allow one resolution change per guest boot, which prevents a > > > > crash when the guest writes garbage to the configuration space (e.g. > > > when rebooting). > > > > Hmm? Did you see that happen in practice? > > It is not eas

Re: [Qemu-devel] [PATCH 2/3] ramfb enhancement

2019-05-09 Thread Hou Qiming
> Only allow one resolution change per guest boot, which prevents a > > crash when the guest writes garbage to the configuration space (e.g. > > when rebooting). > > Hmm? Did you see that happen in practice? > It is not easy to write to fw_cfg by accident ... > > Yes, this does happen in practice

Re: [Qemu-devel] [PATCH 2/3] ramfb enhancement

2019-05-09 Thread Gerd Hoffmann
On Thu, May 09, 2019 at 03:58:02PM +0800, Hou Qiming wrote: > Only allow one resolution change per guest boot, which prevents a > crash when the guest writes garbage to the configuration space (e.g. > when rebooting). Hmm? Did you see that happen in practice? It is not easy to write to fw_cfg by

Re: [Qemu-devel] [PATCH 2/3] ramfb enhancement

2019-05-09 Thread Marcel Apfelbaum
On 5/9/19 10:58 AM, Hou Qiming wrote: The subject for this patch may be:     [PATCH V2 2/3] hw/display/ramfb: don't allow resolution change until vm reset Only allow one resolution change per guest boot, which prevents a crash when the guest writes garbage to the configuration space (e

[Qemu-devel] [PATCH 2/3] ramfb enhancement

2019-05-09 Thread Hou Qiming
Only allow one resolution change per guest boot, which prevents a crash when the guest writes garbage to the configuration space (e.g. when rebooting). Signed-off-by: HOU Qiming --- hw/display/ramfb.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a