Re: [Qemu-devel] [PATCH 2/3] ppce500_pci: remove sysbus_init_mmio_cb2 usage

2011-12-02 Thread Benoît Canet
> > How much did you test this patch, by the way? I've been running into > some odd behaviour with sub-page-sized memory regions which I'm > wondering if you hit here... An e1000 attached as a pci card works fine. (ping and wget www.google.com)

[Qemu-devel] [PATCH 2/3] ppce500_pci: remove sysbus_init_mmio_cb2 usage

2011-12-02 Thread Benoît Canet
Expose only one container MemoryRegion to sysbus. (Peter Maydell's idea) Signed-off-by: Benoît Canet --- hw/ppce500_mpc8544ds.c | 14 ++ hw/ppce500_pci.c | 27 ++- 2 files changed, 16 insertions(+), 25 deletions(-) diff --git a/hw/ppce500_mpc8544ds.

Re: [Qemu-devel] [PATCH 2/3] ppce500_pci: remove sysbus_init_mmio_cb2 usage

2011-12-02 Thread Benoît Canet
> > Is this change actually necessary? If we only have one MMIO region > to map then sysbus_create_varargs() suffices. > > Ack, > How much did you test this patch, by the way? I've been running into > some odd behaviour with sub-page-sized memory regions which I'm > wondering if you hit here... >

Re: [Qemu-devel] [PATCH 2/3] ppce500_pci: remove sysbus_init_mmio_cb2 usage

2011-12-02 Thread Peter Maydell
On 2 December 2011 14:51, Benoît Canet wrote: > @@ -320,10 +321,15 @@ static void mpc8544ds_init(ram_addr_t ram_size, >     sysbus_create_simple("mpc8544-guts", MPC8544_UTIL_BASE, NULL); > >     /* PCI */ > -    dev = sysbus_create_varargs("e500-pcihost", MPC8544_PCI_REGS_BASE, > -