Re: [Qemu-devel] [PATCH 2/3] monitor: remove target-specific code from monitor.c

2015-08-28 Thread Pavel Butsykin
On 28.08.2015 13:12, Peter Maydell wrote: On 28 August 2015 at 10:21, Pavel Butsykin wrote: Yes, this is a good way if we make the interface: const MonitorDef *target_monitor_defs(void); But we can't include the 'monitor/monitor-common.h' to stubs/target-monitor-defs.c, because there is a dep

Re: [Qemu-devel] [PATCH 2/3] monitor: remove target-specific code from monitor.c

2015-08-28 Thread Peter Maydell
On 28 August 2015 at 10:21, Pavel Butsykin wrote: > Yes, this is a good way if we make the interface: const MonitorDef > *target_monitor_defs(void); > But we can't include the 'monitor/monitor-common.h' to > stubs/target-monitor-defs.c, because > there is a dependency with a target-specific header

Re: [Qemu-devel] [PATCH 2/3] monitor: remove target-specific code from monitor.c

2015-08-28 Thread Pavel Butsykin
On 27.08.2015 20:31, Peter Maydell wrote: On 12 August 2015 at 12:50, Denis V. Lunev wrote: From: Pavel Butsykin Move target-specific code out of /monitor.c to /target-*/monitor.c, this will avoid code cluttering and using random ifdeffery. The solution is quite simple, but solves the issu

Re: [Qemu-devel] [PATCH 2/3] monitor: remove target-specific code from monitor.c

2015-08-27 Thread Denis V. Lunev
On 08/27/2015 08:31 PM, Peter Maydell wrote: On 12 August 2015 at 12:50, Denis V. Lunev wrote: From: Pavel Butsykin Move target-specific code out of /monitor.c to /target-*/monitor.c, this will avoid code cluttering and using random ifdeffery. The solution is quite simple, but solves the iss

Re: [Qemu-devel] [PATCH 2/3] monitor: remove target-specific code from monitor.c

2015-08-27 Thread Peter Maydell
On 12 August 2015 at 12:50, Denis V. Lunev wrote: > From: Pavel Butsykin > > Move target-specific code out of /monitor.c to /target-*/monitor.c, > this will avoid code cluttering and using random ifdeffery. The solution > is quite simple, but solves the issue of the separation of target-specific

[Qemu-devel] [PATCH 2/3] monitor: remove target-specific code from monitor.c

2015-08-12 Thread Denis V. Lunev
From: Pavel Butsykin Move target-specific code out of /monitor.c to /target-*/monitor.c, this will avoid code cluttering and using random ifdeffery. The solution is quite simple, but solves the issue of the separation of target-specific code from monitor Signed-off-by: Pavel Butsykin Signed-of

[Qemu-devel] [PATCH 2/3] monitor: remove target-specific code from monitor.c

2015-07-02 Thread Denis V. Lunev
From: Pavel Butsykin Move target-specific code out of /monitor.c to /target-*/monitor.c, this will avoid code cluttering and using random ifdeffery. The solution is quite simple, but solves the issue of the separation of target-specific code from monitor Signed-off-by: Pavel Butsykin Signed-of