Markus Armbruster wrote:
> Juan Quintela writes:
...
>> As qmp command is asynchronous, you can think that -d is *always* on in
>> QMP O:-)
>
> Yes. The existence of "detach" in QMP is owed to limitations of early
> QMP infrastructure. It's flagged as "invalid" and "should not be
> used" sinc
Juan Quintela writes:
> Markus Armbruster wrote:
>> Juan Quintela writes:
>>
>>> Eric Blake wrote:
>
>
Or is the proposal that we are also going to simplify the QMP 'migrate'
command to get rid of crufty parameters?
>>>
>>> I didn't read it that way, but I would not oppose O:-)
>>>
>
* Juan Quintela (quint...@redhat.com) wrote:
> "Dr. David Alan Gilbert" wrote:
>
> >> Forget -b/-i.
> >>
> >> migration_set_parameter compression_threads 8
> >>
> >> migrate
> >>
> >> We don't use compression_threads at all
> >>
> >> migrate_set_capability compress
> >>
> >> migrate
> >>
"Dr. David Alan Gilbert" wrote:
>> Forget -b/-i.
>>
>> migration_set_parameter compression_threads 8
>>
>> migrate
>>
>> We don't use compression_threads at all
>>
>> migrate_set_capability compress
>>
>> migrate
>>
>> Now, we use compression threads.
>>
>> So, compression_threads parame
* Juan Quintela (quint...@redhat.com) wrote:
> "Dr. David Alan Gilbert" wrote:
> > * Juan Quintela (quint...@redhat.com) wrote:
> >> "Dr. David Alan Gilbert" wrote:
> >> > * Juan Quintela (quint...@redhat.com) wrote:
> >> >> Markus Armbruster wrote:
> >> >> > Juan Quintela writes:
> >> >> >
> >
"Dr. David Alan Gilbert" wrote:
> * Juan Quintela (quint...@redhat.com) wrote:
>> "Dr. David Alan Gilbert" wrote:
>> > * Juan Quintela (quint...@redhat.com) wrote:
>> >> Markus Armbruster wrote:
>> >> > Juan Quintela writes:
>> >> >
>> >> >> Eric Blake wrote:
>> >>
>> >>
>> >> >>> Or is the
* Juan Quintela (quint...@redhat.com) wrote:
> "Dr. David Alan Gilbert" wrote:
> > * Juan Quintela (quint...@redhat.com) wrote:
> >> Markus Armbruster wrote:
> >> > Juan Quintela writes:
> >> >
> >> >> Eric Blake wrote:
> >>
> >>
> >> >>> Or is the proposal that we are also going to simplify
"Dr. David Alan Gilbert" wrote:
> * Juan Quintela (quint...@redhat.com) wrote:
>> Markus Armbruster wrote:
>> > Juan Quintela writes:
>> >
>> >> Eric Blake wrote:
>>
>>
>> >>> Or is the proposal that we are also going to simplify the QMP 'migrate'
>> >>> command to get rid of crufty parameter
* Juan Quintela (quint...@redhat.com) wrote:
> Markus Armbruster wrote:
> > Juan Quintela writes:
> >
> >> Eric Blake wrote:
>
>
> >>> Or is the proposal that we are also going to simplify the QMP 'migrate'
> >>> command to get rid of crufty parameters?
> >>
> >> I didn't read it that way, but
Markus Armbruster wrote:
> Juan Quintela writes:
>
>> Eric Blake wrote:
>>> Or is the proposal that we are also going to simplify the QMP 'migrate'
>>> command to get rid of crufty parameters?
>>
>> I didn't read it that way, but I would not oppose O:-)
>>
>> Later, Juan.
>
> I'm not too famil
Juan Quintela writes:
> Eric Blake wrote:
>> On 05/12/2017 05:55 AM, Juan Quintela wrote:
> @@ -1239,6 +1240,7 @@ void qmp_migrate(const char *uri, bool has_blk,
> bool blk,
> }
>
> if (has_inc && inc) {
> +migrate_set_block_enabled(s, true);
>
Eric Blake wrote:
> [adding Markus]
>
> On 05/15/2017 04:48 AM, Juan Quintela wrote:
>> Eric Blake wrote:
>>> On 05/12/2017 05:55 AM, Juan Quintela wrote:
>> @@ -1239,6 +1240,7 @@ void qmp_migrate(const char *uri, bool has_blk,
>> bool blk,
>> }
>>
>> if (has_inc
[adding Markus]
On 05/15/2017 04:48 AM, Juan Quintela wrote:
> Eric Blake wrote:
>> On 05/12/2017 05:55 AM, Juan Quintela wrote:
> @@ -1239,6 +1240,7 @@ void qmp_migrate(const char *uri, bool has_blk,
> bool blk,
> }
>
> if (has_inc && inc) {
> +migrat
* Juan Quintela (quint...@redhat.com) wrote:
> Eric Blake wrote:
> > On 05/12/2017 05:55 AM, Juan Quintela wrote:
> @@ -1239,6 +1240,7 @@ void qmp_migrate(const char *uri, bool has_blk,
> bool blk,
> }
>
> if (has_inc && inc) {
> +migrate_set_bloc
On Fri, May 12, 2017 at 12:55:22PM +0200, Juan Quintela wrote:
> Peter Xu wrote:
> > On Thu, May 11, 2017 at 06:32:27PM +0200, Juan Quintela wrote:
>
> >> @@ -1214,9 +1218,6 @@ void qmp_migrate(const char *uri, bool has_blk, bool
> >> blk,
> >> MigrationParams params;
> >> const char *
Eric Blake wrote:
> On 05/12/2017 05:55 AM, Juan Quintela wrote:
@@ -1239,6 +1240,7 @@ void qmp_migrate(const char *uri, bool has_blk, bool
blk,
}
if (has_inc && inc) {
+migrate_set_block_enabled(s, true);
migrate_set_block_shared(s,
On 05/12/2017 05:55 AM, Juan Quintela wrote:
>>> @@ -1239,6 +1240,7 @@ void qmp_migrate(const char *uri, bool has_blk, bool
>>> blk,
>>> }
>>>
>>> if (has_inc && inc) {
>>> +migrate_set_block_enabled(s, true);
>>> migrate_set_block_shared(s, true);
>>
>> [2]
>>
>> IIUC
Peter Xu wrote:
> On Thu, May 11, 2017 at 06:32:27PM +0200, Juan Quintela wrote:
>> @@ -1214,9 +1218,6 @@ void qmp_migrate(const char *uri, bool has_blk, bool
>> blk,
>> MigrationParams params;
>> const char *p;
>>
>> -params.blk = has_blk && blk;
>> -params.shared = has_inc
On Thu, May 11, 2017 at 06:32:27PM +0200, Juan Quintela wrote:
> We have change in the previous patch to use migration capabilities for
> it. Notice that we continue using the old command line flags from
> migrate command from the time being. Remove the set_params method as
> now it is empty.
>
On 2017/5/12 0:33, Juan Quintela wrote:
Hailiang Zhang wrote:
Hi,
Hmm you don't seem to have replaced this with anything.
I think that's a behavioural change; the trick COLO did (I'm not sure if this
is still the way it works) is that they initiate the first migration
with block migration ena
Hailiang Zhang wrote:
> Hi,
>
>>> Hmm you don't seem to have replaced this with anything.
>>> I think that's a behavioural change; the trick COLO did (I'm not sure if
>>> this
>>> is still the way it works) is that they initiate the first migration
>>> with block migration enabled so that the two
We have change in the previous patch to use migration capabilities for
it. Notice that we continue using the old command line flags from
migrate command from the time being. Remove the set_params method as
now it is empty.
Signed-off-by: Juan Quintela
---
include/migration/migration.h | 3 +--
Hi,
On 2017/5/4 16:51, Juan Quintela wrote:
"Dr. David Alan Gilbert" wrote:
* Juan Quintela (quint...@redhat.com) wrote:
We have change in the previous patch to use migration capabilities for
it. Notice that we continue using the old command line flags from
migrate command from the time bein
"Dr. David Alan Gilbert" wrote:
> * Juan Quintela (quint...@redhat.com) wrote:
>> We have change in the previous patch to use migration capabilities for
>> it. Notice that we continue using the old command line flags from
>> migrate command from the time being. Remove the set_params method as
>>
On 04/25/2017 05:30 AM, Juan Quintela wrote:
> We have change in the previous patch to use migration capabilities for
> it. Notice that we continue using the old command line flags from
> migrate command from the time being. Remove the set_params method as
> now it is empty.
>
> Signed-off-by: J
* Juan Quintela (quint...@redhat.com) wrote:
> We have change in the previous patch to use migration capabilities for
> it. Notice that we continue using the old command line flags from
> migrate command from the time being. Remove the set_params method as
> now it is empty.
>
> Signed-off-by: J
We have change in the previous patch to use migration capabilities for
it. Notice that we continue using the old command line flags from
migrate command from the time being. Remove the set_params method as
now it is empty.
Signed-off-by: Juan Quintela
---
include/migration/migration.h | 3 +--
27 matches
Mail list logo
