Re: [Qemu-devel] [PATCH 2/3] memory: add API for creating ROM/device regions

2011-08-14 Thread Anthony Liguori
On 08/14/2011 10:43 AM, Alexander Graf wrote: Am 14.08.2011 um 06:29 schrieb Anthony Liguori: On 08/13/2011 10:05 PM, Avi Kivity wrote: On 08/12/2011 06:48 AM, Anthony Liguori wrote: target_phys_addr_t offset_in_region; AddrRange addr; uint8_t dirty_log_mask; + bool readable; @@ -125,6 +125

Re: [Qemu-devel] [PATCH 2/3] memory: add API for creating ROM/device regions

2011-08-14 Thread Alexander Graf
Am 14.08.2011 um 06:29 schrieb Anthony Liguori : > On 08/13/2011 10:05 PM, Avi Kivity wrote: >> On 08/12/2011 06:48 AM, Anthony Liguori wrote: target_phys_addr_t offset_in_region; AddrRange addr; uint8_t dirty_log_mask; + bool readable; >>> @@ -125,6 +125,7 @@ struct FlatRange

Re: [Qemu-devel] [PATCH 2/3] memory: add API for creating ROM/device regions

2011-08-14 Thread Anthony Liguori
On 08/13/2011 10:05 PM, Avi Kivity wrote: On 08/12/2011 06:48 AM, Anthony Liguori wrote: target_phys_addr_t offset_in_region; AddrRange addr; uint8_t dirty_log_mask; + bool readable; @@ -125,6 +125,7 @@ struct FlatRange { In a follow up, it might be good to add a comment explaining that this w

Re: [Qemu-devel] [PATCH 2/3] memory: add API for creating ROM/device regions

2011-08-13 Thread Avi Kivity
On 08/12/2011 06:48 AM, Anthony Liguori wrote: target_phys_addr_t offset_in_region; AddrRange addr; uint8_t dirty_log_mask; +bool readable; @@ -125,6 +125,7 @@ struct FlatRange { In a follow up, it might be good to add a comment explaining that this whole readable thing i

Re: [Qemu-devel] [PATCH 2/3] memory: add API for creating ROM/device regions

2011-08-12 Thread Anthony Liguori
On 08/08/2011 11:58 AM, Avi Kivity wrote: ROM/device regions act as mapped RAM for reads, can I/O memory for writes. This allow emulation of flash devices. Signed-off-by: Avi Kivity --- memory.c | 46 -- memory.h | 34 ++

[Qemu-devel] [PATCH 2/3] memory: add API for creating ROM/device regions

2011-08-08 Thread Avi Kivity
ROM/device regions act as mapped RAM for reads, can I/O memory for writes. This allow emulation of flash devices. Signed-off-by: Avi Kivity --- memory.c | 46 -- memory.h | 34 ++ 2 files changed, 78 insertions(+),