Re: [Qemu-devel] [PATCH 2/3] ivshmem: add missing error exit(2)

2013-06-03 Thread Markus Armbruster
Stefan Hajnoczi writes: > If the user fails to specify 'chardev' or 'shm' then we cannot continue. > Exit right away so that we don't invoke shm_open(3) with a NULL pointer. > > It would be nice to replace exit(1) with error returns in the PCI device > .init() function, but leave that for another

[Qemu-devel] [PATCH 2/3] ivshmem: add missing error exit(2)

2013-05-30 Thread Stefan Hajnoczi
If the user fails to specify 'chardev' or 'shm' then we cannot continue. Exit right away so that we don't invoke shm_open(3) with a NULL pointer. It would be nice to replace exit(1) with error returns in the PCI device .init() function, but leave that for another patch since exit(1) is currently u