Re: [Qemu-devel] [PATCH 2/3] chardev: On QIO_CHANNEL_ERR_BROKEN set errno to EPIPE

2018-06-01 Thread Daniel P . Berrangé
On Thu, May 31, 2018 at 09:46:00AM +0200, Sergio Lopez wrote: > This allows callers to identify this potentially unrecoverable error. > --- > chardev/char-io.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/chardev/char-io.c b/chardev/char-io.c > index f810524..f934eb9 100644 > --- a

Re: [Qemu-devel] [PATCH 2/3] chardev: On QIO_CHANNEL_ERR_BROKEN set errno to EPIPE

2018-05-31 Thread Sergio Lopez
On Thu, May 31, 2018 at 11:48:25AM +0200, Marc-André Lureau wrote: > On Thu, May 31, 2018 at 9:46 AM, Sergio Lopez wrote: > > This allows callers to identify this potentially unrecoverable error. > > (missing signed-off) Ouch, sorry, will add it in v2. Sergio.

Re: [Qemu-devel] [PATCH 2/3] chardev: On QIO_CHANNEL_ERR_BROKEN set errno to EPIPE

2018-05-31 Thread Marc-André Lureau
On Thu, May 31, 2018 at 9:46 AM, Sergio Lopez wrote: > This allows callers to identify this potentially unrecoverable error. (missing signed-off) Reviewed-by: Marc-André Lureau > --- > chardev/char-io.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/chardev/char-io.c b/chardev/ch

[Qemu-devel] [PATCH 2/3] chardev: On QIO_CHANNEL_ERR_BROKEN set errno to EPIPE

2018-05-31 Thread Sergio Lopez
This allows callers to identify this potentially unrecoverable error. --- chardev/char-io.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/chardev/char-io.c b/chardev/char-io.c index f810524..f934eb9 100644 --- a/chardev/char-io.c +++ b/chardev/char-io.c @@ -168,6 +168,9 @@ int io_channel_