[Qemu-devel] [PATCH 2/3] block: tell drivers about an image resize

2011-01-24 Thread Christoph Hellwig
Extend the change_cb callback with a reason argument, and use it to tell drivers about size changes. Signed-off-by: Christoph Hellwig Index: qemu/block.c === --- qemu.orig/block.c 2011-01-24 11:56:20.899004129 +0100 +++ qemu/block

Re: [Qemu-devel] [PATCH 2/3] block: tell drivers about an image resize

2011-01-21 Thread Kevin Wolf
Am 19.01.2011 18:02, schrieb Christoph Hellwig: > Extend the change_cb callback with a reason argument, and use it > to tell drivers about size changes. > > Signed-off-by: Christoph Hellwig > > Index: qemu/block.c > === > --- qemu.o

Re: [Qemu-devel] [PATCH 2/3] block: tell drivers about an image resize

2011-01-20 Thread Christoph Hellwig
On Thu, Jan 20, 2011 at 09:14:17AM +, Stefan Hajnoczi wrote: > Cool, this is much nicer than stashing away state like > bs->media_changed = 1. I just took a peek to see if we can remove > that field completely but IDE seems to use it internally. I think we could get rid of it in generic code,

Re: [Qemu-devel] [PATCH 2/3] block: tell drivers about an image resize

2011-01-20 Thread Stefan Hajnoczi
On Wed, Jan 19, 2011 at 5:02 PM, Christoph Hellwig wrote: > Extend the change_cb callback with a reason argument, and use it > to tell drivers about size changes. > > Signed-off-by: Christoph Hellwig > > Index: qemu/block.c > === > -

[Qemu-devel] [PATCH 2/3] block: tell drivers about an image resize

2011-01-19 Thread Christoph Hellwig
Extend the change_cb callback with a reason argument, and use it to tell drivers about size changes. Signed-off-by: Christoph Hellwig Index: qemu/block.c === --- qemu.orig/block.c 2011-01-18 20:54:45.246021572 +0100 +++ qemu/block

Re: [Qemu-devel] [PATCH 2/3] block: tell drivers about an image resize

2011-01-17 Thread Christoph Hellwig
> Do we want to check to ensure the size_changed flag isn't set before > doing a second resize event? I'm wondering if the truncate takes > $longtime and user gets impatient and issues a second resize command. > How should we respond? Ignore it? queue it up? The truncate is synchronous and the

Re: [Qemu-devel] [PATCH 2/3] block: tell drivers about an image resize

2011-01-14 Thread Ryan Harper
* Christoph Hellwig [2011-01-14 10:27]: > Add a new size_changed flag in the BlockDriverState and call the > change_cb callback to notify drivers about a size change. > > Signed-off-by: Christoph Hellwig > > Index: qemu/block.c > =

[Qemu-devel] [PATCH 2/3] block: tell drivers about an image resize

2011-01-14 Thread Christoph Hellwig
Add a new size_changed flag in the BlockDriverState and call the change_cb callback to notify drivers about a size change. Signed-off-by: Christoph Hellwig Index: qemu/block.c === --- qemu.orig/block.c 2011-01-14 17:05:49.52700336