Re: [Qemu-devel] [PATCH 2/3] arm_mptimer: Fix ONE-SHOT -> PERIODIC mode change

2015-07-04 Thread Dmitry Osipenko
04.07.2015 22:36, Peter Crosthwaite пишет: Your do-nothing code paths are now inconsistent between the 0 and 1 cases. I think this if can be consolidated with: if (value & 1) { if ((old & 1) && (tb->count != 0)) { break; } if (tb->control & 2) { ... }

Re: [Qemu-devel] [PATCH 2/3] arm_mptimer: Fix ONE-SHOT -> PERIODIC mode change

2015-07-04 Thread Peter Crosthwaite
On Thu, Jul 2, 2015 at 3:52 PM, Dmitry Osipenko wrote: > Timer won't start periodic ticking if ONE-SHOT -> PERIODIC mode change > happened > after one-shot tick was completed. Fix it by starting ticking only if timer > was > disabled previously and isn't ticking right now. > > Signed-off-by: Dmi

[Qemu-devel] [PATCH 2/3] arm_mptimer: Fix ONE-SHOT -> PERIODIC mode change

2015-07-02 Thread Dmitry Osipenko
Timer won't start periodic ticking if ONE-SHOT -> PERIODIC mode change happened after one-shot tick was completed. Fix it by starting ticking only if timer was disabled previously and isn't ticking right now. Signed-off-by: Dmitry Osipenko --- hw/timer/arm_mptimer.c | 9 +++-- 1 file changed