Re: [Qemu-devel] [PATCH 2/2 (RFC)] QEMU: SMBIOS: Build full smbios tables

2014-03-06 Thread Laszlo Ersek
On 03/06/14 17:09, Gabriel L. Somlo wrote: > On Thu, Mar 06, 2014 at 10:03:32AM +0100, Gerd Hoffmann wrote: >> >> You don't need to worry about live migration, but the smbios stuff >> clearly goes into the guest-visible change category. >> >> smbios_type1_defaults is one of the compatibility contro

Re: [Qemu-devel] [PATCH 2/2 (RFC)] QEMU: SMBIOS: Build full smbios tables

2014-03-06 Thread Gabriel L. Somlo
On Thu, Mar 06, 2014 at 10:03:32AM +0100, Gerd Hoffmann wrote: > > You don't need to worry about live migration, but the smbios stuff > clearly goes into the guest-visible change category. > > smbios_type1_defaults is one of the compatibility controls. It is false > for 1.7 (+older) machine type

Re: [Qemu-devel] [PATCH 2/2 (RFC)] QEMU: SMBIOS: Build full smbios tables

2014-03-06 Thread Gerd Hoffmann
On Mi, 2014-03-05 at 09:48 -0500, Gabriel L. Somlo wrote: > On Wed, Mar 05, 2014 at 11:59:44AM +0100, Gerd Hoffmann wrote: > > > -static bool smbios_type1_defaults = true; > > > +static bool smbios_defaults = true; > > > /* Make sure that guest addresses aligned at 1Gbyte boundaries get > > > map

Re: [Qemu-devel] [PATCH 2/2 (RFC)] QEMU: SMBIOS: Build full smbios tables

2014-03-05 Thread Gabriel L. Somlo
On Wed, Mar 05, 2014 at 11:59:44AM +0100, Gerd Hoffmann wrote: > > -static bool smbios_type1_defaults = true; > > +static bool smbios_defaults = true; > > /* Make sure that guest addresses aligned at 1Gbyte boundaries get mapped > > to > > * host addresses aligned at 1Gbyte boundaries. This wa

Re: [Qemu-devel] [PATCH 2/2 (RFC)] QEMU: SMBIOS: Build full smbios tables

2014-03-05 Thread Gerd Hoffmann
On Di, 2014-03-04 at 14:20 -0500, Gabriel L. Somlo wrote: >- deprecate passing individual smbios fields (SMBIOS_FIELD_ENTRY) >- added functionality to build full tables instead, and pass them > to the bios via fw_cfg as SMBIOS_TABLE_ENTRY blobs >- added code to optionally build typ

Re: [Qemu-devel] [PATCH 2/2 (RFC)] QEMU: SMBIOS: Build full smbios tables

2014-03-04 Thread Kevin O'Connor
On Tue, Mar 04, 2014 at 02:20:06PM -0500, Gabriel L. Somlo wrote: > Kevin and Gerd: I'd like to get your acked-by for this patch (or any > future revision): you're the two people who've been editing src/fw/smbios.c > in SeaBIOS, and while I didn't directly cut'n'paste anything from there, > I did i

[Qemu-devel] [PATCH 2/2 (RFC)] QEMU: SMBIOS: Build full smbios tables

2014-03-04 Thread Gabriel L. Somlo
- deprecate passing individual smbios fields (SMBIOS_FIELD_ENTRY) - added functionality to build full tables instead, and pass them to the bios via fw_cfg as SMBIOS_TABLE_ENTRY blobs - added code to optionally build type 2 smbios table expected by OS X Signed-off-by: Gabriel Somlo -