Re: [Qemu-devel] [PATCH 2/2] vmstate, memory: decouple vmstate from memory API

2012-01-07 Thread Stefan Weil
Am 08.01.2012 06:14, schrieb Jordan Justen: Avi, When using pflash_cfi01, I hit the assert(new_block) added above. It seemed to be caused by the low bits of addr being 0x7. This seems to be come from cpu_register_io_memory in memory_region_init_rom_device. Would this patch be an appropriate fi

Re: [Qemu-devel] [PATCH 2/2] vmstate, memory: decouple vmstate from memory API

2012-01-07 Thread Jordan Justen
On Tue, Dec 20, 2011 at 06:05, Avi Kivity wrote: > +void qemu_ram_set_idstr(ram_addr_t addr, const char *name, DeviceState *dev) >  { >     RAMBlock *new_block, *block; > > -    size = TARGET_PAGE_ALIGN(size); > -    new_block = g_malloc0(sizeof(*new_block)); > +    new_block = NULL; > +    QLIST_

Re: [Qemu-devel] [PATCH 2/2] vmstate, memory: decouple vmstate from memory API

2011-12-20 Thread Avi Kivity
On 12/20/2011 04:09 PM, Anthony Liguori wrote: > On 12/20/2011 08:05 AM, Avi Kivity wrote: >> Currently creating a memory region automatically registers it for >> live migration. This differs from other state (which is enumerated >> in a VMStateDescription structure) and ties the live migration co