Re: [Qemu-devel] [PATCH 2/2] vmdk: Add read-only support for seSparse snapshots

2019-05-28 Thread Max Reitz
On 28.05.19 09:57, Sam Eiderman wrote: > Comments inline > >> On 27 May 2019, at 20:39, Max Reitz > > wrote: >> >> On 24.04.19 09:49, Sam Eiderman wrote: [...] >>> @@ -498,10 +543,15 @@ static int vmdk_init_tables(BlockDriverState >>> *bs, VmdkExtent *extent, >>>   

Re: [Qemu-devel] [PATCH 2/2] vmdk: Add read-only support for seSparse snapshots

2019-05-28 Thread Sam Eiderman
Comments inline > On 27 May 2019, at 20:39, Max Reitz wrote: > > On 24.04.19 09:49, Sam Eiderman wrote: >> Until ESXi 6.5 VMware used the vmfsSparse format for snapshots (VMDK3 in >> QEMU). >> >> This format was lacking in the following: >> >>* Grain directory (L1) and grain table (L2) ent

Re: [Qemu-devel] [PATCH 2/2] vmdk: Add read-only support for seSparse snapshots

2019-05-27 Thread Max Reitz
On 24.04.19 09:49, Sam Eiderman wrote: > Until ESXi 6.5 VMware used the vmfsSparse format for snapshots (VMDK3 in > QEMU). > > This format was lacking in the following: > > * Grain directory (L1) and grain table (L2) entries were 32-bit, > allowing access to only 2TB (slightly less) of

[Qemu-devel] [PATCH 2/2] vmdk: Add read-only support for seSparse snapshots

2019-04-24 Thread Sam Eiderman
Until ESXi 6.5 VMware used the vmfsSparse format for snapshots (VMDK3 in QEMU). This format was lacking in the following: * Grain directory (L1) and grain table (L2) entries were 32-bit, allowing access to only 2TB (slightly less) of data. * The grain size (default) was 512 bytes -