Re: [Qemu-devel] [PATCH 2/2] vfio-powerpc: added VFIO support

2012-07-12 Thread Alexey Kardashevskiy
On 12/07/12 13:11, Alex Williamson wrote: > On Wed, 2012-07-11 at 12:54 +1000, Alexey Kardashevskiy wrote: >> On 11/07/12 02:55, Alex Williamson wrote: >>> On Tue, 2012-07-10 at 15:51 +1000, Alexey Kardashevskiy wrote: The patch enables VFIO on POWER. It literally does the following:

Re: [Qemu-devel] [PATCH 2/2] vfio-powerpc: added VFIO support

2012-07-11 Thread Alex Williamson
On Wed, 2012-07-11 at 12:54 +1000, Alexey Kardashevskiy wrote: > On 11/07/12 02:55, Alex Williamson wrote: > > On Tue, 2012-07-10 at 15:51 +1000, Alexey Kardashevskiy wrote: > >> The patch enables VFIO on POWER. > >> > >> It literally does the following: > >> > >> 1. POWERPC IOMMU support (the kern

Re: [Qemu-devel] [PATCH 2/2] vfio-powerpc: added VFIO support

2012-07-10 Thread Benjamin Herrenschmidt
On Wed, 2012-07-11 at 12:54 +1000, Alexey Kardashevskiy wrote: > > Why do you need this, aren't the extension checks sufficient for this to > > be a nop for you? > > > It uses ioapic_remove_gsi_eoi_notifier() so it needs some #ifdef anyway. And > as we do not support > kvm_irqchip_in_kernel(), t

Re: [Qemu-devel] [PATCH 2/2] vfio-powerpc: added VFIO support

2012-07-10 Thread Alexey Kardashevskiy
On 11/07/12 02:55, Alex Williamson wrote: > On Tue, 2012-07-10 at 15:51 +1000, Alexey Kardashevskiy wrote: >> The patch enables VFIO on POWER. >> >> It literally does the following: >> >> 1. POWERPC IOMMU support (the kernel counterpart is required) >> >> 2. Added #ifdef TARGET_PPC64 for EOI handle

Re: [Qemu-devel] [PATCH 2/2] vfio-powerpc: added VFIO support

2012-07-10 Thread Benjamin Herrenschmidt
On Wed, 2012-07-11 at 10:17 +1000, Alexey Kardashevskiy wrote: > So the current one would be SPAPR_TCE_32? No, the iommu type is SPAPR_TCE, but the *window* info you get here is the 32-bit window. My thinking is add some versionning and a bunch of reserved fields to that info struct so we can stic

Re: [Qemu-devel] [PATCH 2/2] vfio-powerpc: added VFIO support

2012-07-10 Thread Alexey Kardashevskiy
On 11/07/12 10:04, Benjamin Herrenschmidt wrote: > On Wed, 2012-07-11 at 09:55 +1000, Alexey Kardashevskiy wrote: >> On 11/07/12 08:26, Scott Wood wrote: >>> On 07/10/2012 12:51 AM, Alexey Kardashevskiy wrote: The patch enables VFIO on POWER. It literally does the following: >>>

Re: [Qemu-devel] [PATCH 2/2] vfio-powerpc: added VFIO support

2012-07-10 Thread Benjamin Herrenschmidt
On Wed, 2012-07-11 at 09:55 +1000, Alexey Kardashevskiy wrote: > On 11/07/12 08:26, Scott Wood wrote: > > On 07/10/2012 12:51 AM, Alexey Kardashevskiy wrote: > >> The patch enables VFIO on POWER. > >> > >> It literally does the following: > >> > >> 1. POWERPC IOMMU support (the kernel counterpart i

Re: [Qemu-devel] [PATCH 2/2] vfio-powerpc: added VFIO support

2012-07-10 Thread Alexey Kardashevskiy
On 11/07/12 08:26, Scott Wood wrote: > On 07/10/2012 12:51 AM, Alexey Kardashevskiy wrote: >> The patch enables VFIO on POWER. >> >> It literally does the following: >> >> 1. POWERPC IOMMU support (the kernel counterpart is required) > [snip] >> +/* API for POWERPC IOMMU */ >> + >

Re: [Qemu-devel] [PATCH 2/2] vfio-powerpc: added VFIO support

2012-07-10 Thread Scott Wood
On 07/10/2012 12:51 AM, Alexey Kardashevskiy wrote: > The patch enables VFIO on POWER. > > It literally does the following: > > 1. POWERPC IOMMU support (the kernel counterpart is required) [snip] > +/* API for POWERPC IOMMU */ > + > +#define POWERPC_IOMMU 2 > + > +str

Re: [Qemu-devel] [PATCH 2/2] vfio-powerpc: added VFIO support

2012-07-10 Thread Benjamin Herrenschmidt
On Tue, 2012-07-10 at 15:48 -0600, Alex Williamson wrote: > > specific hypervisor calls, not sure what a MemoryListener would do > > here ... > > Hmm, the guest directed iommu updates via hypercalls may not really fit > the MemoryListener model. I'm just trying to think of ways to avoid > having

Re: [Qemu-devel] [PATCH 2/2] vfio-powerpc: added VFIO support

2012-07-10 Thread Alex Williamson
On Wed, 2012-07-11 at 07:32 +1000, Benjamin Herrenschmidt wrote: > On Tue, 2012-07-10 at 10:55 -0600, Alex Williamson wrote: > > > > I wish you could do this through a MemoryListener like we do on x86. > > > > Can you elaborate ? TCE (iommu) manipulation on PAPR is done via > specific hypervisor

Re: [Qemu-devel] [PATCH 2/2] vfio-powerpc: added VFIO support

2012-07-10 Thread Benjamin Herrenschmidt
On Tue, 2012-07-10 at 10:55 -0600, Alex Williamson wrote: > > I wish you could do this through a MemoryListener like we do on x86. > Can you elaborate ? TCE (iommu) manipulation on PAPR is done via specific hypervisor calls, not sure what a MemoryListener would do here ... Cheers, Ben.

Re: [Qemu-devel] [PATCH 2/2] vfio-powerpc: added VFIO support

2012-07-10 Thread Alex Williamson
On Tue, 2012-07-10 at 15:51 +1000, Alexey Kardashevskiy wrote: > The patch enables VFIO on POWER. > > It literally does the following: > > 1. POWERPC IOMMU support (the kernel counterpart is required) > > 2. Added #ifdef TARGET_PPC64 for EOI handlers initialisation. > > 3. Added vfio_get_contai

[Qemu-devel] [PATCH 2/2] vfio-powerpc: added VFIO support

2012-07-09 Thread Alexey Kardashevskiy
The patch enables VFIO on POWER. It literally does the following: 1. POWERPC IOMMU support (the kernel counterpart is required) 2. Added #ifdef TARGET_PPC64 for EOI handlers initialisation. 3. Added vfio_get_container_fd() to VFIO in order to initialize 1). 4. Makefile fixed and "is_vfio" flag