Re: [Qemu-devel] [PATCH 2/2] vfio: Fix 128 bit handling

2013-08-21 Thread Paolo Bonzini
Il 22/08/2013 04:02, Alexey Kardashevskiy ha scritto: >> Int128 is opaque, please use int128_and. To build the constant you have >> three choices (from my preferred to IMHO worst): >> >> - add a new int128_exts64 function that sign-extends an int64_t > > Like this? I am really scared to screw her

Re: [Qemu-devel] [PATCH 2/2] vfio: Fix 128 bit handling

2013-08-21 Thread Alexey Kardashevskiy
On 08/21/2013 08:07 PM, Paolo Bonzini wrote: > Il 21/08/2013 11:28, Alexey Kardashevskiy ha scritto: >> Upcoming VFIO on SPAPR PPC64 support will initialize the IOMMU >> memory region with UINT64_MAX (2^64 bytes) size so int128_get64() >> will assert. >> >> The patch takes care of this check. The e

Re: [Qemu-devel] [PATCH 2/2] vfio: Fix 128 bit handling

2013-08-21 Thread Paolo Bonzini
Il 21/08/2013 11:28, Alexey Kardashevskiy ha scritto: > Upcoming VFIO on SPAPR PPC64 support will initialize the IOMMU > memory region with UINT64_MAX (2^64 bytes) size so int128_get64() > will assert. > > The patch takes care of this check. The existing type1 IOMMU code > is not expected to map a

[Qemu-devel] [PATCH 2/2] vfio: Fix 128 bit handling

2013-08-21 Thread Alexey Kardashevskiy
Upcoming VFIO on SPAPR PPC64 support will initialize the IOMMU memory region with UINT64_MAX (2^64 bytes) size so int128_get64() will assert. The patch takes care of this check. The existing type1 IOMMU code is not expected to map all 64 bits of RAM so the patch does not touch that part. Signed-o