Re: [Qemu-devel] [PATCH 2/2] tap-win32: disable broken async write path

2015-11-18 Thread Andrew Baumann
From: Stefan Weil [mailto:s...@weilnetz.de] Sent: Tuesday, 17 November 2015 23:40 > > +#ifdef DEBUG_TAP_WIN32 > > +LPVOID msgbuf; > > Does this also work ... > > char *msgbuf; > > > > +error = GetLastError(); > > + > FormatMessage(FORMAT_MESSAGE_ALLOCATE_BUFFER|FORMAT_MESSA

Re: [Qemu-devel] [PATCH 2/2] tap-win32: disable broken async write path

2015-11-17 Thread Stefan Weil
Am 17.11.2015 um 20:09 schrieb Andrew Baumann: > The code under the TUN_ASYNCHRONOUS_WRITES path makes two incorrect > assumptions about the behaviour of the WriteFile API for overlapped > file handles. First, WriteFile does not update the > lpNumberOfBytesWritten parameter when the overlapped para

[Qemu-devel] [PATCH 2/2] tap-win32: disable broken async write path

2015-11-17 Thread Andrew Baumann
The code under the TUN_ASYNCHRONOUS_WRITES path makes two incorrect assumptions about the behaviour of the WriteFile API for overlapped file handles. First, WriteFile does not update the lpNumberOfBytesWritten parameter when the overlapped parameter is non-NULL (the number of bytes written is known