Re: [Qemu-devel] [PATCH 2/2] scripts: qom-tree: add support of path as argument

2015-05-19 Thread Andreas Färber
Am 14.05.2015 um 13:47 schrieb Paolo Bonzini: > On 14/05/2015 13:41, Martin Cerveny wrote: >> Hello. >> >> Ternary/if/else >= python 2.5 (I use the same coding as in >> scripts/qmp/qemu-ga-client). > > Oh, that's old. Shows my knowledge of Python. > > Then your patch is okay---thanks for endurin

Re: [Qemu-devel] [PATCH 2/2] scripts: qom-tree: add support of path as argument

2015-05-14 Thread Paolo Bonzini
On 14/05/2015 13:41, Martin Cerveny wrote: > Hello. > > Ternary/if/else >= python 2.5 (I use the same coding as in > scripts/qmp/qemu-ga-client). Oh, that's old. Shows my knowledge of Python. Then your patch is okay---thanks for enduring with me. :) Paolo > "import json" >= python 2.6 (scri

Re: [Qemu-devel] [PATCH 2/2] scripts: qom-tree: add support of path as argument

2015-05-14 Thread Martin Cerveny
Hello. Ternary/if/else >= python 2.5 (I use the same coding as in scripts/qmp/qemu-ga-client). "import json" >= python 2.6 (scripts/qmp/qmp.py) "import argparse" >= python 2.7 (scripts/analyze-migration.py, scripts/vmstate-static-checker.py) "import optparse" < python 2.7 (deprecated, scripts/q

Re: [Qemu-devel] [PATCH 2/2] scripts: qom-tree: add support of path as argument

2015-05-14 Thread Paolo Bonzini
On 13/05/2015 14:14, Martin Cerveny wrote: > for item in items: > if item['type'].startswith('child<'): > -list_node(path + '/' + item['name']) > +list_node((path if (path != '/') else '') + '/' + item['name']) I'm not sure which Python version introduced i

[Qemu-devel] [PATCH 2/2] scripts: qom-tree: add support of path as argument

2015-05-13 Thread Martin Cerveny
Add processing of optional argument path as "tree base". Signed-off-by: Martin Cerveny --- scripts/qmp/qom-tree |9 +++-- 1 files changed, 7 insertions(+), 2 deletions(-) diff --git a/scripts/qmp/qom-tree b/scripts/qmp/qom-tree index 07f8a9d..c3e3738 100755 --- a/scripts/qmp/qom-tree ++