Re: [Qemu-devel] [PATCH 2/2] register: fix incorrect read mask

2017-02-10 Thread Philippe Mathieu-Daudé
On 02/10/2017 07:19 PM, Alistair Francis wrote: On Mon, Feb 6, 2017 at 3:39 PM, Philippe Mathieu-Daudé wrote: The register_read() function expects a bitmask argument. Signed-off-by: Philippe Mathieu-Daudé The functionality of these two patches looks good to me. I think it's weird that we

Re: [Qemu-devel] [PATCH 2/2] register: fix incorrect read mask

2017-02-10 Thread Alistair Francis
On Mon, Feb 6, 2017 at 3:39 PM, Philippe Mathieu-Daudé wrote: > The register_read() function expects a bitmask argument. > > Signed-off-by: Philippe Mathieu-Daudé The functionality of these two patches looks good to me. I think it's weird that we convert the write function in one patch (when we

[Qemu-devel] [PATCH 2/2] register: fix incorrect read mask

2017-02-06 Thread Philippe Mathieu-Daudé
The register_read() function expects a bitmask argument. Signed-off-by: Philippe Mathieu-Daudé --- hw/core/register.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/hw/core/register.c b/hw/core/register.c index 12f4c1e62d..482e3f827a 100644 --- a/hw/core/register.c +++