Re: [Qemu-devel] [PATCH 2/2] rdma: simplify qemu_rdma_register_and_get_keys()

2013-09-20 Thread Isaku Yamahata
On Wed, Sep 18, 2013 at 11:01:16AM -0400, Michael R. Hines wrote: > The value of chunk_end changes based on whether or not the value of > block->is_ram_block is true of false. When is block->is_ram_block set to false? Looking at __qemu_rdma_add_block() and qemu_rdma_init_ram_blocks(), is_ram_blo

Re: [Qemu-devel] [PATCH 2/2] rdma: simplify qemu_rdma_register_and_get_keys()

2013-09-20 Thread Michael R. Hines
On 09/20/2013 12:59 PM, Isaku Yamahata wrote: On Wed, Sep 18, 2013 at 11:01:16AM -0400, Michael R. Hines wrote: The value of chunk_end changes based on whether or not the value of block->is_ram_block is true of false. When is block->is_ram_block set to false? Looking at __qemu_rdma_add_block()

Re: [Qemu-devel] [PATCH 2/2] rdma: simplify qemu_rdma_register_and_get_keys()

2013-09-18 Thread Michael R. Hines
On 09/03/2013 10:32 PM, Isaku Yamahata wrote: Signed-off-by: Isaku Yamahata --- migration-rdma.c | 23 +++ 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/migration-rdma.c b/migration-rdma.c index db5a908..941c07e 100644 --- a/migration-rdma.c +++ b/migrat

Re: [Qemu-devel] [PATCH 2/2] rdma: simplify qemu_rdma_register_and_get_keys()

2013-09-18 Thread Juan Quintela
Isaku Yamahata wrote: > Signed-off-by: Isaku Yamahata I don't understand this bit: > +uint8_t *chunk_start = ram_chunk_start(block, chunk); > +uint8_t *chunk_end = ram_chunk_end(block, chunk); Here we are getting just the length of a chunk > sge.length = length; > >

[Qemu-devel] [PATCH 2/2] rdma: simplify qemu_rdma_register_and_get_keys()

2013-09-03 Thread Isaku Yamahata
Signed-off-by: Isaku Yamahata --- migration-rdma.c | 23 +++ 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/migration-rdma.c b/migration-rdma.c index db5a908..941c07e 100644 --- a/migration-rdma.c +++ b/migration-rdma.c @@ -1128,8 +1128,7 @@ static int qemu_r