Re: [Qemu-devel] [PATCH 2/2] qemu-kvm: Add svm cpuid features

2010-09-18 Thread garymber...@gmail.com
Sent from my HTC on the Now Network from Sprint! - Reply message - From: "Avi Kivity" Date: Sun, Sep 12, 2010 6:22 am Subject: [Qemu-devel] [PATCH 2/2] qemu-kvm: Add svm cpuid features To: "Alexander Graf" Cc: "Joerg Roedel" , "Joerg Roedel&

Re: [Qemu-devel] [PATCH 2/2] qemu-kvm: Add svm cpuid features

2010-09-12 Thread Joerg Roedel
On Sun, Sep 12, 2010 at 10:01:28AM +0200, Avi Kivity wrote: > On 09/12/2010 09:16 AM, Alexander Graf wrote: >> Either way, I don't think we need a phenom2 type. The features >> additional are minor enough to not really matter and all use cases I >> can come up with require either -cpu host (local

Re: [Qemu-devel] [PATCH 2/2] qemu-kvm: Add svm cpuid features

2010-09-12 Thread Avi Kivity
On 09/12/2010 04:30 PM, Joerg Roedel wrote: Either way, I don't think we need a phenom2 type. The features additional are minor enough to not really matter and all use cases I can come up with require either -cpu host (local virt) or -cpu phenom (migration). I'm fine with this (or with adding

Re: [Qemu-devel] [PATCH 2/2] qemu-kvm: Add svm cpuid features

2010-09-12 Thread Avi Kivity
On 09/12/2010 01:14 PM, Alexander Graf wrote: Uh, something in the power management module. Just give it a try on an Istambul system. Just use the 11.1 iso - the kernels are close enough. Oh, probably some silly msr. -- error compiling committee.c: too many arguments to function

Re: [Qemu-devel] [PATCH 2/2] qemu-kvm: Add svm cpuid features

2010-09-12 Thread Alexander Graf
Am 12.09.2010 um 12:22 schrieb Avi Kivity : > On 09/12/2010 12:06 PM, Alexander Graf wrote: For the Phenom type, I honestly don't remember why, but there was also a good reason to add it. In fact, I use it today to have nested virt without -cpu host on hardware that's too new for

Re: [Qemu-devel] [PATCH 2/2] qemu-kvm: Add svm cpuid features

2010-09-12 Thread Avi Kivity
On 09/12/2010 12:06 PM, Alexander Graf wrote: For the Phenom type, I honestly don't remember why, but there was also a good reason to add it. In fact, I use it today to have nested virt without -cpu host on hardware that's too new for my guests. Curious, what guests balk at modern hardware bu

Re: [Qemu-devel] [PATCH 2/2] qemu-kvm: Add svm cpuid features

2010-09-12 Thread Alexander Graf
Am 12.09.2010 um 10:01 schrieb Avi Kivity : > On 09/12/2010 09:16 AM, Alexander Graf wrote: Depends on which Phenom you have. A Phenom II has NRIPSAVE but the old Phenoms don't have it. For the SVM features it is not that important what the host hardware supports but what KVM

Re: [Qemu-devel] [PATCH 2/2] qemu-kvm: Add svm cpuid features

2010-09-12 Thread Avi Kivity
On 09/12/2010 09:16 AM, Alexander Graf wrote: Depends on which Phenom you have. A Phenom II has NRIPSAVE but the old Phenoms don't have it. For the SVM features it is not that important what the host hardware supports but what KVM can emulate. VMCBCLEAN can be emulated without supporting it in

Re: [Qemu-devel] [PATCH 2/2] qemu-kvm: Add svm cpuid features

2010-09-12 Thread Alexander Graf
On 12.09.2010, at 08:05, Avi Kivity wrote: > On 09/11/2010 05:20 PM, Joerg Roedel wrote: >> On Sat, Sep 11, 2010 at 03:43:02PM +0200, Alexander Graf wrote: @@ -305,6 +322,8 @@ static x86_def_t builtin_x86_defs[] = { CPUID_EXT3_OSVW, CPUID_EXT3_IBS */ .ex

Re: [Qemu-devel] [PATCH 2/2] qemu-kvm: Add svm cpuid features

2010-09-11 Thread Avi Kivity
On 09/11/2010 05:20 PM, Joerg Roedel wrote: On Sat, Sep 11, 2010 at 03:43:02PM +0200, Alexander Graf wrote: @@ -305,6 +322,8 @@ static x86_def_t builtin_x86_defs[] = { CPUID_EXT3_OSVW, CPUID_EXT3_IBS */ .ext3_features = CPUID_EXT3_LAHF_LM | CPUID_EXT3_SVM |

Re: [Qemu-devel] [PATCH 2/2] qemu-kvm: Add svm cpuid features

2010-09-11 Thread Alexander Graf
On 11.09.2010, at 16:42, Joerg Roedel wrote: > On Sat, Sep 11, 2010 at 04:38:51PM +0200, Alexander Graf wrote: >>> I am not sure that I am the right person to do such an invasive change. >>> At least not in this patch-set. I could think of removing SVM from the >>> qemu64 definition and add it ag

Re: [Qemu-devel] [PATCH 2/2] qemu-kvm: Add svm cpuid features

2010-09-11 Thread Joerg Roedel
On Sat, Sep 11, 2010 at 04:38:51PM +0200, Alexander Graf wrote: > > I am not sure that I am the right person to do such an invasive change. > > At least not in this patch-set. I could think of removing SVM from the > > qemu64 definition and add it again in the TCG specific path. > > It's not an in

Re: [Qemu-devel] [PATCH 2/2] qemu-kvm: Add svm cpuid features

2010-09-11 Thread Alexander Graf
On 11.09.2010, at 16:36, Joerg Roedel wrote: > On Sat, Sep 11, 2010 at 04:29:18PM +0200, Alexander Graf wrote: >>> Depends on which Phenom you have. A Phenom II has NRIPSAVE but the old >>> Phenoms don't have it. For the SVM features it is not that important >>> what the host hardware supports bu

Re: [Qemu-devel] [PATCH 2/2] qemu-kvm: Add svm cpuid features

2010-09-11 Thread Joerg Roedel
On Sat, Sep 11, 2010 at 04:29:18PM +0200, Alexander Graf wrote: > > Depends on which Phenom you have. A Phenom II has NRIPSAVE but the old > > Phenoms don't have it. For the SVM features it is not that important > > what the host hardware supports but what KVM can emulate. VMCBCLEAN can > > be emul

Re: [Qemu-devel] [PATCH 2/2] qemu-kvm: Add svm cpuid features

2010-09-11 Thread Alexander Graf
On 11.09.2010, at 16:20, Joerg Roedel wrote: > On Sat, Sep 11, 2010 at 03:43:02PM +0200, Alexander Graf wrote: >>> @@ -305,6 +322,8 @@ static x86_def_t builtin_x86_defs[] = { >>>CPUID_EXT3_OSVW, CPUID_EXT3_IBS */ >>>.ext3_features = CPUID_EXT3_LAHF_LM | CPUID_EXT3_SVM

Re: [Qemu-devel] [PATCH 2/2] qemu-kvm: Add svm cpuid features

2010-09-11 Thread Joerg Roedel
On Sat, Sep 11, 2010 at 03:43:02PM +0200, Alexander Graf wrote: > > @@ -305,6 +322,8 @@ static x86_def_t builtin_x86_defs[] = { > > CPUID_EXT3_OSVW, CPUID_EXT3_IBS */ > > .ext3_features = CPUID_EXT3_LAHF_LM | CPUID_EXT3_SVM | > > CPUID_EXT3_ABM | CPUID_EXT3_S

Re: [Qemu-devel] [PATCH 2/2] qemu-kvm: Add svm cpuid features

2010-09-11 Thread Alexander Graf
On 10.09.2010, at 17:38, Joerg Roedel wrote: > This patch adds the svm cpuid feature flags to the qemu > intialization path. > > Signed-off-by: Joerg Roedel > --- > target-i386/cpu.h | 12 +++ > target-i386/cpuid.c | 80 --- > target-i386/

[Qemu-devel] [PATCH 2/2] qemu-kvm: Add svm cpuid features

2010-09-10 Thread Joerg Roedel
This patch adds the svm cpuid feature flags to the qemu intialization path. Signed-off-by: Joerg Roedel --- target-i386/cpu.h | 12 +++ target-i386/cpuid.c | 80 --- target-i386/kvm.c |3 ++ 3 files changed, 78 insertions(+), 17 del