Re: [Qemu-devel] [PATCH 2/2] qdev: fix NULL deference

2012-03-14 Thread Andreas Färber
Am 14.03.2012 08:59, schrieb Markus Armbruster: > Andreas Färber writes: > >> Am 13.03.2012 19:32, schrieb Mark Langsdorf: >>> From: Joshua Housh >>> >>> Make sure a BusInfo exists before trying to dereference it. >> >> What's the use case that breaks? > > Valid question. > > Every qdev has /

Re: [Qemu-devel] [PATCH 2/2] qdev: fix NULL deference

2012-03-14 Thread Markus Armbruster
Andreas Färber writes: > Am 13.03.2012 19:32, schrieb Mark Langsdorf: >> From: Joshua Housh >> >> Make sure a BusInfo exists before trying to dereference it. > > What's the use case that breaks? Valid question. Every qdev has / used to have a parent bus, and every bus info. If that's not tru

Re: [Qemu-devel] [PATCH 2/2] qdev: fix NULL deference

2012-03-13 Thread Andreas Färber
Am 13.03.2012 19:32, schrieb Mark Langsdorf: > From: Joshua Housh > > Make sure a BusInfo exists before trying to dereference it. What's the use case that breaks? Andreas > > Signed-off-by: Joshua Housh > Signed-off-by: Mark Langsdorf > --- > hw/qdev.c |9 ++--- > 1 files changed,

[Qemu-devel] [PATCH 2/2] qdev: fix NULL deference

2012-03-13 Thread Mark Langsdorf
From: Joshua Housh Make sure a BusInfo exists before trying to dereference it. Signed-off-by: Joshua Housh Signed-off-by: Mark Langsdorf --- hw/qdev.c |9 ++--- 1 files changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/qdev.c b/hw/qdev.c index ee21d90..6c3d02f 100644 --- a/hw/