Re: [Qemu-devel] [PATCH 2/2] qapi: Allow blockdev-add for NBD

2016-02-04 Thread Daniel P. Berrange
On Thu, Feb 04, 2016 at 02:08:23PM +0100, Kevin Wolf wrote: > Am 03.02.2016 um 18:06 hat Daniel P. Berrange geschrieben: > > On Wed, Feb 03, 2016 at 05:33:16PM +0100, Max Reitz wrote: > > > We have to introduce a new object (BlockdevOptionsNbd) for several > > > reasons: > > > - Neither of InetSock

Re: [Qemu-devel] [PATCH 2/2] qapi: Allow blockdev-add for NBD

2016-02-04 Thread Kevin Wolf
Am 03.02.2016 um 18:06 hat Daniel P. Berrange geschrieben: > On Wed, Feb 03, 2016 at 05:33:16PM +0100, Max Reitz wrote: > > We have to introduce a new object (BlockdevOptionsNbd) for several > > reasons: > > - Neither of InetSocketAddress nor UnixSocketAddress alone is > > sufficient, because bot

Re: [Qemu-devel] [PATCH 2/2] qapi: Allow blockdev-add for NBD

2016-02-04 Thread Paolo Bonzini
On 03/02/2016 18:16, Max Reitz wrote: > However, the issue remains that the NBD block driver expects > flattened options which is syntactically incompatible to > SocketAddress. Maybe the best way to address this would be to just > make block/nbd.c directly accept a SocketAddress and keep the old

Re: [Qemu-devel] [PATCH 2/2] qapi: Allow blockdev-add for NBD

2016-02-04 Thread Paolo Bonzini
On 03/02/2016 17:48, Eric Blake wrote: > On 02/03/2016 09:33 AM, Max Reitz wrote: >> We have to introduce a new object (BlockdevOptionsNbd) for >> several reasons: - Neither of InetSocketAddress nor >> UnixSocketAddress alone is sufficient, because both are >> supported - We cannot use SocketAddr

Re: [Qemu-devel] [PATCH 2/2] qapi: Allow blockdev-add for NBD

2016-02-03 Thread Max Reitz
On 03.02.2016 17:48, Eric Blake wrote: > On 02/03/2016 09:33 AM, Max Reitz wrote: >> We have to introduce a new object (BlockdevOptionsNbd) for several >> reasons: >> - Neither of InetSocketAddress nor UnixSocketAddress alone is >> sufficient, because both are supported >> - We cannot use SocketA

Re: [Qemu-devel] [PATCH 2/2] qapi: Allow blockdev-add for NBD

2016-02-03 Thread Max Reitz
On 03.02.2016 18:06, Daniel P. Berrange wrote: > On Wed, Feb 03, 2016 at 05:33:16PM +0100, Max Reitz wrote: >> We have to introduce a new object (BlockdevOptionsNbd) for several >> reasons: >> - Neither of InetSocketAddress nor UnixSocketAddress alone is >> sufficient, because both are supported

Re: [Qemu-devel] [PATCH 2/2] qapi: Allow blockdev-add for NBD

2016-02-03 Thread Daniel P. Berrange
On Wed, Feb 03, 2016 at 05:33:16PM +0100, Max Reitz wrote: > We have to introduce a new object (BlockdevOptionsNbd) for several > reasons: > - Neither of InetSocketAddress nor UnixSocketAddress alone is > sufficient, because both are supported > - We cannot use SocketAddress because NBD does not

Re: [Qemu-devel] [PATCH 2/2] qapi: Allow blockdev-add for NBD

2016-02-03 Thread Eric Blake
On 02/03/2016 09:33 AM, Max Reitz wrote: > We have to introduce a new object (BlockdevOptionsNbd) for several > reasons: > - Neither of InetSocketAddress nor UnixSocketAddress alone is > sufficient, because both are supported > - We cannot use SocketAddress because NBD does not support an fd, >

[Qemu-devel] [PATCH 2/2] qapi: Allow blockdev-add for NBD

2016-02-03 Thread Max Reitz
We have to introduce a new object (BlockdevOptionsNbd) for several reasons: - Neither of InetSocketAddress nor UnixSocketAddress alone is sufficient, because both are supported - We cannot use SocketAddress because NBD does not support an fd, and because it is not a flat union which BlockdevOpt