Re: [Qemu-devel] [PATCH 2/2] monitor: add proper reference counting of the current CPU

2017-10-16 Thread Greg Kurz
On Mon, 16 Oct 2017 10:07:18 +0200 Igor Mammedov wrote: > On Fri, 13 Oct 2017 12:05:46 +0200 > Greg Kurz wrote: > > > On Fri, 13 Oct 2017 11:24:59 +0200 > > Igor Mammedov wrote: > > > > > On Fri, 13 Oct 2017 10:35:31 +0200 > > > Greg Kurz wrote: > > > > > > > If a CPU selected with th

Re: [Qemu-devel] [PATCH 2/2] monitor: add proper reference counting of the current CPU

2017-10-16 Thread Igor Mammedov
On Fri, 13 Oct 2017 12:05:46 +0200 Greg Kurz wrote: > On Fri, 13 Oct 2017 11:24:59 +0200 > Igor Mammedov wrote: > > > On Fri, 13 Oct 2017 10:35:31 +0200 > > Greg Kurz wrote: > > > > > If a CPU selected with the "cpu" command is hot-unplugged then "info cpus" > > > causes QEMU to exit: > > >

Re: [Qemu-devel] [PATCH 2/2] monitor: add proper reference counting of the current CPU

2017-10-13 Thread Greg Kurz
On Fri, 13 Oct 2017 11:24:59 +0200 Igor Mammedov wrote: > On Fri, 13 Oct 2017 10:35:31 +0200 > Greg Kurz wrote: > > > If a CPU selected with the "cpu" command is hot-unplugged then "info cpus" > > causes QEMU to exit: > > > > (qemu) device_del cpu1 > > (qemu) info cpus > > qemu:qemu_cpu_kick_t

Re: [Qemu-devel] [PATCH 2/2] monitor: add proper reference counting of the current CPU

2017-10-13 Thread Igor Mammedov
On Fri, 13 Oct 2017 10:35:31 +0200 Greg Kurz wrote: > If a CPU selected with the "cpu" command is hot-unplugged then "info cpus" > causes QEMU to exit: > > (qemu) device_del cpu1 > (qemu) info cpus > qemu:qemu_cpu_kick_thread: No such process > > This happens because "cpu" stores the pointer to

[Qemu-devel] [PATCH 2/2] monitor: add proper reference counting of the current CPU

2017-10-13 Thread Greg Kurz
If a CPU selected with the "cpu" command is hot-unplugged then "info cpus" causes QEMU to exit: (qemu) device_del cpu1 (qemu) info cpus qemu:qemu_cpu_kick_thread: No such process This happens because "cpu" stores the pointer to the selected CPU into the monitor structure. When the CPU is hot-unpl