Re: [Qemu-devel] [PATCH 2/2] hw/arm/virt: don't use a15memmap directly

2015-10-12 Thread Andrew Jones
On Mon, Oct 12, 2015 at 10:00:19AM +0300, Pavel Fedin wrote: > Hello! > > > Before this patch it would complain that the requested > > number of cpus was greater than 123, but for gicv2 configs, it > > should complain that the number is greater than 8. > > Actually, gicv2 code has own check, an

Re: [Qemu-devel] [PATCH 2/2] hw/arm/virt: don't use a15memmap directly

2015-10-12 Thread Pavel Fedin
Hello! > Before this patch it would complain that the requested > number of cpus was greater than 123, but for gicv2 configs, it > should complain that the number is greater than 8. Actually, gicv2 code has own check, and it would complain about >8 CPU (see arm_gic_common_realize()). Kind rega

Re: [Qemu-devel] [PATCH 2/2] hw/arm/virt: don't use a15memmap directly

2015-10-09 Thread Andrew Jones
On Fri, Oct 09, 2015 at 05:45:24PM +0100, Peter Maydell wrote: > On 6 October 2015 at 15:37, Andrew Jones wrote: > > We should always go through VirtBoardInfo when we need the memmap. > > To avoid using a15memmap directly, in this case, we need to defer > > the max-cpus check from class init time

Re: [Qemu-devel] [PATCH 2/2] hw/arm/virt: don't use a15memmap directly

2015-10-09 Thread Peter Maydell
On 6 October 2015 at 15:37, Andrew Jones wrote: > We should always go through VirtBoardInfo when we need the memmap. > To avoid using a15memmap directly, in this case, we need to defer > the max-cpus check from class init time to instance init time. In > class init we now use MAX_CPUMASK_BITS for

[Qemu-devel] [PATCH 2/2] hw/arm/virt: don't use a15memmap directly

2015-10-06 Thread Andrew Jones
We should always go through VirtBoardInfo when we need the memmap. To avoid using a15memmap directly, in this case, we need to defer the max-cpus check from class init time to instance init time. In class init we now use MAX_CPUMASK_BITS for max_cpus initialization, which is the maximum QEMU suppor