Re: [Qemu-devel] [PATCH 2/2] hw/arm/allwinner-a10: initialize EMAC

2014-01-08 Thread Peter Crosthwaite
On Wed, Jan 8, 2014 at 5:27 PM, Li Guang wrote: > Beniamino Galvani wrote: >> >> On Mon, Jan 06, 2014 at 08:49:18AM +0800, Li Guang wrote: >> >>> >>> Hi, >>> please use prefix AwA10 for names instead of Aw, >>> also PATCH 1/2. >>> >> >> Hi, >> >> I agree with you that there is an inconsistency in

Re: [Qemu-devel] [PATCH 2/2] hw/arm/allwinner-a10: initialize EMAC

2014-01-07 Thread Li Guang
Beniamino Galvani wrote: On Mon, Jan 06, 2014 at 08:49:18AM +0800, Li Guang wrote: Hi, please use prefix AwA10 for names instead of Aw, also PATCH 1/2. Hi, I agree with you that there is an inconsistency in the naming of EMAC and other A10 devices (timer, interrupt controller). But

Re: [Qemu-devel] [PATCH 2/2] hw/arm/allwinner-a10: initialize EMAC

2014-01-06 Thread Beniamino Galvani
On Mon, Jan 06, 2014 at 08:49:18AM +0800, Li Guang wrote: > Hi, > please use prefix AwA10 for names instead of Aw, > also PATCH 1/2. Hi, I agree with you that there is an inconsistency in the naming of EMAC and other A10 devices (timer, interrupt controller). But the EMAC core is used not only o

Re: [Qemu-devel] [PATCH 2/2] hw/arm/allwinner-a10: initialize EMAC

2014-01-05 Thread Li Guang
Hi, please use prefix AwA10 for names instead of Aw, also PATCH 1/2. Thanks for your effort on this! Beniamino Galvani wrote: Signed-off-by: Beniamino Galvani --- hw/arm/allwinner-a10.c | 20 include/hw/arm/allwinner-a10.h |4 2 files changed, 24 inser

Re: [Qemu-devel] [PATCH 2/2] hw/arm/allwinner-a10: initialize EMAC

2014-01-02 Thread Peter Crosthwaite
On Fri, Jan 3, 2014 at 3:19 AM, Beniamino Galvani wrote: > On Thu, Jan 02, 2014 at 08:20:12PM +1000, Peter Crosthwaite wrote: >> On Thu, Jan 2, 2014 at 7:18 PM, Beniamino Galvani >> wrote: >> > Signed-off-by: Beniamino Galvani >> > --- >> > hw/arm/allwinner-a10.c | 20 +++

Re: [Qemu-devel] [PATCH 2/2] hw/arm/allwinner-a10: initialize EMAC

2014-01-02 Thread Beniamino Galvani
On Thu, Jan 02, 2014 at 08:20:12PM +1000, Peter Crosthwaite wrote: > On Thu, Jan 2, 2014 at 7:18 PM, Beniamino Galvani wrote: > > Signed-off-by: Beniamino Galvani > > --- > > hw/arm/allwinner-a10.c | 20 > > include/hw/arm/allwinner-a10.h |4 > > 2 files c

Re: [Qemu-devel] [PATCH 2/2] hw/arm/allwinner-a10: initialize EMAC

2014-01-02 Thread Peter Crosthwaite
On Thu, Jan 2, 2014 at 8:20 PM, Peter Crosthwaite wrote: > On Thu, Jan 2, 2014 at 7:18 PM, Beniamino Galvani wrote: >> Signed-off-by: Beniamino Galvani >> --- >> hw/arm/allwinner-a10.c | 20 >> include/hw/arm/allwinner-a10.h |4 >> 2 files changed, 24 ins

Re: [Qemu-devel] [PATCH 2/2] hw/arm/allwinner-a10: initialize EMAC

2014-01-02 Thread Peter Crosthwaite
On Thu, Jan 2, 2014 at 7:18 PM, Beniamino Galvani wrote: > Signed-off-by: Beniamino Galvani > --- > hw/arm/allwinner-a10.c | 20 > include/hw/arm/allwinner-a10.h |4 > 2 files changed, 24 insertions(+) > > diff --git a/hw/arm/allwinner-a10.c b/hw/arm/allwi

[Qemu-devel] [PATCH 2/2] hw/arm/allwinner-a10: initialize EMAC

2014-01-02 Thread Beniamino Galvani
Signed-off-by: Beniamino Galvani --- hw/arm/allwinner-a10.c | 20 include/hw/arm/allwinner-a10.h |4 2 files changed, 24 insertions(+) diff --git a/hw/arm/allwinner-a10.c b/hw/arm/allwinner-a10.c index 4658e19..155e026 100644 --- a/hw/arm/allwinner-a10.c +