Re: [Qemu-devel] [PATCH 2/2] checkpatch.pl: make C99 comments a warning, not error

2011-04-02 Thread Stefan Hajnoczi
On Fri, Apr 1, 2011 at 7:46 PM, Blue Swirl wrote: > I think the only reasonable use for C99 comments is > //#define DEBUG_xyz > for quickly enabling debugging printfs. > > But even this pattern should be replaced by tracepoints, since they > are much better. So I'd prefer to keep the ERROR. Pleas

Re: [Qemu-devel] [PATCH 2/2] checkpatch.pl: make C99 comments a warning, not error

2011-04-01 Thread Blue Swirl
On Fri, Apr 1, 2011 at 6:20 PM, Michael Roth wrote: > C99 comments are pretty heavilly used in QEMU, and don't violate > anything mentioned in HACKING/CODING_STYLE. Make them warnings instead. > > Signed-off-by: Michael Roth > --- >  scripts/checkpatch.pl |    2 +- >  test.c                |    5

Re: [Qemu-devel] [PATCH 2/2] checkpatch.pl: make C99 comments a warning, not error

2011-04-01 Thread Stefan Hajnoczi
On Fri, Apr 1, 2011 at 4:20 PM, Michael Roth wrote: > C99 comments are pretty heavilly used in QEMU, and don't violate > anything mentioned in HACKING/CODING_STYLE. Make them warnings instead. > > Signed-off-by: Michael Roth > --- >  scripts/checkpatch.pl |    2 +- >  test.c                |    5

[Qemu-devel] [PATCH 2/2] checkpatch.pl: make C99 comments a warning, not error

2011-04-01 Thread Michael Roth
C99 comments are pretty heavilly used in QEMU, and don't violate anything mentioned in HACKING/CODING_STYLE. Make them warnings instead. Signed-off-by: Michael Roth --- scripts/checkpatch.pl |2 +- test.c|5 + 2 files changed, 6 insertions(+), 1 deletions(-) create m