Re: [Qemu-devel] [PATCH 2/2] ac97: don't override the pci subsystem id

2011-11-08 Thread Gerd Hoffmann
Hi, >>> Wouldn't it be better to have the subsystem vendor and device id be >>> configurable, set the default to the qemu subsystem ids, and then set it >>> to 8086: for < 1.0? >> >> I don't want this being fully configurable just for the snake of >> backward compatibility with old qemu vers

Re: [Qemu-devel] [PATCH 2/2] ac97: don't override the pci subsystem id

2011-11-08 Thread Avi Kivity
On 11/08/2011 10:08 AM, Gerd Hoffmann wrote: > On 11/07/11 17:00, Anthony Liguori wrote: > > On 11/07/2011 09:33 AM, Gerd Hoffmann wrote: > >> This patch removes the code lines which set the subsystem id for the > >> emulated ac97 card to 8086:. Due to the device id being zero the > >> subsyst

Re: [Qemu-devel] [PATCH 2/2] ac97: don't override the pci subsystem id

2011-11-08 Thread Gerd Hoffmann
On 11/07/11 17:00, Anthony Liguori wrote: > On 11/07/2011 09:33 AM, Gerd Hoffmann wrote: >> This patch removes the code lines which set the subsystem id for the >> emulated ac97 card to 8086:. Due to the device id being zero the >> subsystem id isn't vaild anyway. With the patch applied the s

Re: [Qemu-devel] [PATCH 2/2] ac97: don't override the pci subsystem id

2011-11-07 Thread Anthony Liguori
On 11/07/2011 09:33 AM, Gerd Hoffmann wrote: This patch removes the code lines which set the subsystem id for the emulated ac97 card to 8086:. Due to the device id being zero the subsystem id isn't vaild anyway. With the patch applied the sound card gets the default qemu subsystem id (1af4:

[Qemu-devel] [PATCH 2/2] ac97: don't override the pci subsystem id

2011-11-07 Thread Gerd Hoffmann
This patch removes the code lines which set the subsystem id for the emulated ac97 card to 8086:. Due to the device id being zero the subsystem id isn't vaild anyway. With the patch applied the sound card gets the default qemu subsystem id (1af4:1100) instead. [ v2: old & broken id is mainta