Re: [Qemu-devel] [PATCH 2/2] Compile time checks for newer glib

2015-06-01 Thread John Snow
On 05/29/2015 12:01 PM, Dr. David Alan Gilbert wrote: > * Peter Maydell (peter.mayd...@linaro.org) wrote: >> On 29 May 2015 at 16:01, Dr. David Alan Gilbert (git) >> wrote: >>> --- a/include/glib-compat.h >>> +++ b/include/glib-compat.h >>> @@ -16,6 +16,12 @@ >>> #ifndef QEMU_GLIB_COMPAT_H >>>

Re: [Qemu-devel] [PATCH 2/2] Compile time checks for newer glib

2015-05-29 Thread Dr. David Alan Gilbert
* Peter Maydell (peter.mayd...@linaro.org) wrote: > On 29 May 2015 at 16:01, Dr. David Alan Gilbert (git) > wrote: > > --- a/include/glib-compat.h > > +++ b/include/glib-compat.h > > @@ -16,6 +16,12 @@ > > #ifndef QEMU_GLIB_COMPAT_H > > #define QEMU_GLIB_COMPAT_H > > > > +/* > > + * The source f

Re: [Qemu-devel] [PATCH 2/2] Compile time checks for newer glib

2015-05-29 Thread Peter Maydell
On 29 May 2015 at 16:01, Dr. David Alan Gilbert (git) wrote: > --- a/include/glib-compat.h > +++ b/include/glib-compat.h > @@ -16,6 +16,12 @@ > #ifndef QEMU_GLIB_COMPAT_H > #define QEMU_GLIB_COMPAT_H > > +/* > + * The source file including this compat header knows it's using newer glib > + * fun

Re: [Qemu-devel] [PATCH 2/2] Compile time checks for newer glib

2015-05-29 Thread Dr. David Alan Gilbert
* Paolo Bonzini (pbonz...@redhat.com) wrote: > > > On 29/05/2015 17:01, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > > > Newer glib has support for checking that applications aren't > > using newer glib calls than they should be. > > > > The support for the check

Re: [Qemu-devel] [PATCH 2/2] Compile time checks for newer glib

2015-05-29 Thread Paolo Bonzini
On 29/05/2015 17:01, Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Newer glib has support for checking that applications aren't > using newer glib calls than they should be. > > The support for the check only went into glib 2.32 and it only > has macros for version 2

[Qemu-devel] [PATCH 2/2] Compile time checks for newer glib

2015-05-29 Thread Dr. David Alan Gilbert (git)
From: "Dr. David Alan Gilbert" Newer glib has support for checking that applications aren't using newer glib calls than they should be. The support for the check only went into glib 2.32 and it only has macros for version 2.26 upwards; although we only insist on 2.22 at the moment, I set the gli