Re: [Qemu-devel] [PATCH 2/2] 9pfs: fix memory leak about xattr value

2016-10-10 Thread Greg Kurz
On Mon, 10 Oct 2016 17:15:10 +0800 Li Qiang wrote: > Oops! I have made this patch to dress the memory leak in v9fs_xattrcreate I guess you mean v9fs_xattrwalk(). There is no possible memory leak with v9fs_xattrwalk() because xattr_fidp comes from alloc_fid(). The leak can only occur when xattr_

Re: [Qemu-devel] [PATCH 2/2] 9pfs: fix memory leak about xattr value

2016-10-10 Thread Li Qiang
Oops! I have made this patch to dress the memory leak in v9fs_xattrcreate but forget this and make another mistake. I mean we should call g_free for xattr.value first in xattr create. This avoid the memory leak. static void v9fs_xattrcreate(void *opaque) { ... g_free(xattr_fidp->fs.xattr.v

Re: [Qemu-devel] [PATCH 2/2] 9pfs: fix memory leak about xattr value

2016-10-10 Thread Greg Kurz
On Sat, 8 Oct 2016 22:27:08 -0700 Li Qiang wrote: > From: Li Qiang > > The 'fs.xattr.value' field in V9fsFidState object doesn't consider > the situation that this field has been allocated previously. Every > time, it will be allocated directly. This leads a host memory leak > issue. This pat

[Qemu-devel] [PATCH 2/2] 9pfs: fix memory leak about xattr value

2016-10-08 Thread Li Qiang
From: Li Qiang The 'fs.xattr.value' field in V9fsFidState object doesn't consider the situation that this field has been allocated previously. Every time, it will be allocated directly. This leads a host memory leak issue. This patch fix this. Signed-off-by: Li Qiang --- hw/9pfs/9p.c | 7