Re: [Qemu-devel] [PATCH 18/25] check: Only test pvpanic when it is compiled in

2018-07-17 Thread Thomas Huth
On 17.07.2018 13:33, Juan Quintela wrote: > There was not possible to compile out pvpanic. Use the same trick > that applesmc. Either "It is not possible" or "There is no possibility" ? And that "that" in the second sentence also sounds wrong. Apart from that: Reviewed-by: Thomas Huth

[Qemu-devel] [PATCH 18/25] check: Only test pvpanic when it is compiled in

2018-07-17 Thread Juan Quintela
There was not possible to compile out pvpanic. Use the same trick that applesmc. Signed-off-by: Juan Quintela --- hw/misc/pvpanic.c | 11 --- include/hw/misc/pvpanic.h | 11 ++- tests/Makefile.include| 4 ++-- 3 files changed, 12 insertions(+), 14 deletions(-) diff