Re: [Qemu-devel] [PATCH 18/22] target-i386: move APIC to ICC bus

2013-04-09 Thread Paolo Bonzini
Il 05/04/2013 16:37, Igor Mammedov ha scritto: > @@ -282,12 +284,14 @@ static int apic_load_old(QEMUFile *f, void *opaque, int > version_id) > return 0; > } > > -static int apic_init_common(SysBusDevice *dev) > +static int apic_init_common(ICCDevice *dev) > { > APICCommonState *s = A

[Qemu-devel] [PATCH 18/22] target-i386: move APIC to ICC bus

2013-04-05 Thread Igor Mammedov
... to allow it to be hotplugged * map APIC's mmio at board level if it is present Signed-off-by: Igor Mammedov --- v2: * fix compile error "cpu may be used uninitialized" with --enable-werror but without --enable-debug. --- hw/apic_common.c | 17 - hw/apic_internal.h

Re: [Qemu-devel] [PATCH 18/22] target-i386: move APIC to ICC bus

2013-04-05 Thread Igor Mammedov
On Fri, 5 Apr 2013 13:15:03 -0300 Eduardo Habkost wrote: > On Fri, Apr 05, 2013 at 04:37:10PM +0200, Igor Mammedov wrote: > [...] > > void pc_cpus_init(const char *cpu_model) > > { > > int i; > > +X86CPU *cpu; > > Error *error = NULL; > > +SysBusDevice *ib; > > > > /* i

Re: [Qemu-devel] [PATCH 18/22] target-i386: move APIC to ICC bus

2013-04-05 Thread Eduardo Habkost
On Fri, Apr 05, 2013 at 04:37:10PM +0200, Igor Mammedov wrote: [...] > void pc_cpus_init(const char *cpu_model) > { > int i; > +X86CPU *cpu; > Error *error = NULL; > +SysBusDevice *ib; > > /* init CPUs */ > if (cpu_model == NULL) { > @@ -902,14 +907,22 @@ void pc_cpu

[Qemu-devel] [PATCH 18/22] target-i386: move APIC to ICC bus

2013-04-05 Thread Igor Mammedov
... to allow it to be hotplugged * map APIC's mmio at board level if it is present Signed-off-by: Igor Mammedov --- hw/apic_common.c | 17 - hw/apic_internal.h | 6 +++--- hw/i386/kvmvapic.c | 1 + hw/i386/pc.c | 19 --- hw/icc_bus.c | 15 +++