Re: [Qemu-devel] [PATCH 18/21] qcow2: Add function for refcount order amendment

2014-11-12 Thread Eric Blake
On 11/12/2014 10:45 AM, Max Reitz wrote: > On 2014-11-12 at 15:21, Max Reitz wrote: >> On 2014-11-12 at 15:19, Eric Blake wrote: >>> On 11/10/2014 06:45 AM, Max Reitz wrote: Add a function qcow2_change_refcount_order() which allows changing the refcount order of a qcow2 image. >>> A thoug

Re: [Qemu-devel] [PATCH 18/21] qcow2: Add function for refcount order amendment

2014-11-12 Thread Max Reitz
On 2014-11-12 at 15:21, Max Reitz wrote: On 2014-11-12 at 15:19, Eric Blake wrote: On 11/10/2014 06:45 AM, Max Reitz wrote: Add a function qcow2_change_refcount_order() which allows changing the refcount order of a qcow2 image. A thought: didn't you just submit a patch that marked the image as

Re: [Qemu-devel] [PATCH 18/21] qcow2: Add function for refcount order amendment

2014-11-12 Thread Max Reitz
On 2014-11-12 at 15:19, Eric Blake wrote: On 11/10/2014 06:45 AM, Max Reitz wrote: Add a function qcow2_change_refcount_order() which allows changing the refcount order of a qcow2 image. A thought: didn't you just submit a patch that marked the image as dirty, nuked the on-disk refcount, then r

Re: [Qemu-devel] [PATCH 18/21] qcow2: Add function for refcount order amendment

2014-11-12 Thread Eric Blake
On 11/10/2014 06:45 AM, Max Reitz wrote: > Add a function qcow2_change_refcount_order() which allows changing the > refcount order of a qcow2 image. A thought: didn't you just submit a patch that marked the image as dirty, nuked the on-disk refcount, then rebuilt one using the in-memory refcounts?

Re: [Qemu-devel] [PATCH 18/21] qcow2: Add function for refcount order amendment

2014-11-12 Thread Eric Blake
On 11/12/2014 02:55 AM, Max Reitz wrote: > On 2014-11-12 at 05:15, Eric Blake wrote: >> On 11/10/2014 06:45 AM, Max Reitz wrote: >>> Add a function qcow2_change_refcount_order() which allows changing the >>> refcount order of a qcow2 image. >>> >>> Signed-off-by: Max Reitz >>> --- >>> block/qcow

Re: [Qemu-devel] [PATCH 18/21] qcow2: Add function for refcount order amendment

2014-11-12 Thread Max Reitz
On 2014-11-12 at 05:15, Eric Blake wrote: On 11/10/2014 06:45 AM, Max Reitz wrote: Add a function qcow2_change_refcount_order() which allows changing the refcount order of a qcow2 image. Signed-off-by: Max Reitz --- block/qcow2-refcount.c | 424 +++

Re: [Qemu-devel] [PATCH 18/21] qcow2: Add function for refcount order amendment

2014-11-11 Thread Eric Blake
On 11/10/2014 06:45 AM, Max Reitz wrote: > Add a function qcow2_change_refcount_order() which allows changing the > refcount order of a qcow2 image. > > Signed-off-by: Max Reitz > --- > block/qcow2-refcount.c | 424 > + > block/qcow2.h |

[Qemu-devel] [PATCH 18/21] qcow2: Add function for refcount order amendment

2014-11-10 Thread Max Reitz
Add a function qcow2_change_refcount_order() which allows changing the refcount order of a qcow2 image. Signed-off-by: Max Reitz --- block/qcow2-refcount.c | 424 + block/qcow2.h | 4 + 2 files changed, 428 insertions(+) diff --git a/bl