Re: [Qemu-devel] [PATCH 17/42] job: Move defer_to_main_loop to Job

2018-05-16 Thread Eric Blake
On 05/09/2018 11:26 AM, Kevin Wolf wrote: Signed-off-by: Kevin Wolf --- Rather sparse on the commit message, given the other comments in this thread. +++ b/include/qemu/job.h @@ -58,6 +58,9 @@ typedef struct Job { */ bool cancelled; +/** Set to true when the job has def

Re: [Qemu-devel] [PATCH 17/42] job: Move defer_to_main_loop to Job

2018-05-16 Thread Eric Blake
On 05/16/2018 05:51 AM, Max Reitz wrote: -static void commit_complete(BlockJob *job, void *opaque) +static void commit_complete(Job *job, void *opaque) { -CommitBlockJob *s = container_of(job, CommitBlockJob, common); +CommitBlockJob *s = container_of(job, CommitBlockJob, common.job);

Re: [Qemu-devel] [PATCH 17/42] job: Move defer_to_main_loop to Job

2018-05-16 Thread Max Reitz
On 2018-05-15 14:17, Kevin Wolf wrote: > Am 14.05.2018 um 17:52 hat Max Reitz geschrieben: >> On 2018-05-09 18:26, Kevin Wolf wrote: >>> Signed-off-by: Kevin Wolf >>> --- >>> include/block/blockjob.h | 5 >>> include/block/blockjob_int.h | 19 --- >>> include/qemu/job.h

Re: [Qemu-devel] [PATCH 17/42] job: Move defer_to_main_loop to Job

2018-05-15 Thread Kevin Wolf
Am 15.05.2018 um 00:33 hat John Snow geschrieben: > > > On 05/09/2018 12:26 PM, Kevin Wolf wrote: > > Signed-off-by: Kevin Wolf > > Hmm, this one is a bit more than just code motion due to the way the > aio_context acquisition has changed. I think at a minimum a good commit > message is warrant

Re: [Qemu-devel] [PATCH 17/42] job: Move defer_to_main_loop to Job

2018-05-15 Thread Kevin Wolf
Am 14.05.2018 um 17:52 hat Max Reitz geschrieben: > On 2018-05-09 18:26, Kevin Wolf wrote: > > Signed-off-by: Kevin Wolf > > --- > > include/block/blockjob.h | 5 > > include/block/blockjob_int.h | 19 --- > > include/qemu/job.h | 20 > > block/bac

Re: [Qemu-devel] [PATCH 17/42] job: Move defer_to_main_loop to Job

2018-05-14 Thread John Snow
On 05/09/2018 12:26 PM, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf Hmm, this one is a bit more than just code motion due to the way the aio_context acquisition has changed. I think at a minimum a good commit message is warranted. > --- > include/block/blockjob.h | 5 > include/b

Re: [Qemu-devel] [PATCH 17/42] job: Move defer_to_main_loop to Job

2018-05-14 Thread Max Reitz
On 2018-05-09 18:26, Kevin Wolf wrote: > Signed-off-by: Kevin Wolf > --- > include/block/blockjob.h | 5 > include/block/blockjob_int.h | 19 --- > include/qemu/job.h | 20 > block/backup.c | 7 +++--- > block/commit.c

[Qemu-devel] [PATCH 17/42] job: Move defer_to_main_loop to Job

2018-05-09 Thread Kevin Wolf
Signed-off-by: Kevin Wolf --- include/block/blockjob.h | 5 include/block/blockjob_int.h | 19 --- include/qemu/job.h | 20 block/backup.c | 7 +++--- block/commit.c | 11 + block/mirror.c | 15 +++