Re: [Qemu-devel] [PATCH 17/23] migration: make sure we always have a migration state

2011-10-06 Thread Orit Wasserman
On 10/05/2011 10:25 PM, Juan Quintela wrote: Anthony Liguori wrote: On 10/04/2011 09:49 AM, Juan Quintela wrote: Anthony Liguori wrote: On 09/23/2011 07:57 AM, Juan Quintela wrote: [ much more stuff ] It avoids s==NULL checks, In favor of s->state == MIG_STATE_NONE. and it also avoids

Re: [Qemu-devel] [PATCH 17/23] migration: make sure we always have a migration state

2011-10-05 Thread Juan Quintela
Anthony Liguori wrote: > On 10/04/2011 09:49 AM, Juan Quintela wrote: >> Anthony Liguori wrote: >>> On 09/23/2011 07:57 AM, Juan Quintela wrote: [ much more stuff ] >> It avoids s==NULL checks, > > In favor of s->state == MIG_STATE_NONE. > >> and it also avoids having to have new >> variables (

Re: [Qemu-devel] [PATCH 17/23] migration: make sure we always have a migration state

2011-10-05 Thread Anthony Liguori
On 10/04/2011 09:49 AM, Juan Quintela wrote: Anthony Liguori wrote: On 09/23/2011 07:57 AM, Juan Quintela wrote: This cleans up a lot the code as we don't have to check anymore if the variable is NULL or not. We don't make it static, because when we integrate fault tolerance, we can have seve

Re: [Qemu-devel] [PATCH 17/23] migration: make sure we always have a migration state

2011-10-04 Thread Juan Quintela
Anthony Liguori wrote: > On 09/23/2011 07:57 AM, Juan Quintela wrote: >> This cleans up a lot the code as we don't have to check anymore if >> the variable is NULL or not. >> >> We don't make it static, because when we integrate fault tolerance, we >> can have several migrations at once. >> >> Sig

Re: [Qemu-devel] [PATCH 17/23] migration: make sure we always have a migration state

2011-10-04 Thread Anthony Liguori
On 09/23/2011 07:57 AM, Juan Quintela wrote: This cleans up a lot the code as we don't have to check anymore if the variable is NULL or not. We don't make it static, because when we integrate fault tolerance, we can have several migrations at once. Signed-off-by: Juan Quintela --- migration.c

[Qemu-devel] [PATCH 17/23] migration: make sure we always have a migration state

2011-09-23 Thread Juan Quintela
This cleans up a lot the code as we don't have to check anymore if the variable is NULL or not. We don't make it static, because when we integrate fault tolerance, we can have several migrations at once. Signed-off-by: Juan Quintela --- migration.c | 126 +--

[Qemu-devel] [PATCH 17/23] migration: make sure we always have a migration state

2011-09-20 Thread Juan Quintela
This cleans up a lot the code as we don't have to check anymore if the variable is NULL or not. We don't make it static, because when we integrate fault tolerance, we can have several migrations at once. Signed-off-by: Juan Quintela --- migration.c | 126 +--