Re: [Qemu-devel] [PATCH 16/30] hw/sh4: use the BYTE-based definitions

2018-02-15 Thread Philippe Mathieu-Daudé
On Thu, Feb 15, 2018 at 11:43 AM, Eric Blake wrote: > On 02/14/2018 10:28 PM, Philippe Mathieu-Daudé wrote: >> >> It ease code review, unit is explicit. > > > I noticed it here, then see it occurs throughout the series: > s/ease/eases/ in the commit message. Oops, thanks Eric I'll fix in respin.

Re: [Qemu-devel] [PATCH 16/30] hw/sh4: use the BYTE-based definitions

2018-02-15 Thread Eric Blake
On 02/14/2018 10:28 PM, Philippe Mathieu-Daudé wrote: It ease code review, unit is explicit. I noticed it here, then see it occurs throughout the series: s/ease/eases/ in the commit message. Signed-off-by: Philippe Mathieu-Daudé --- hw/block/tc58128.c | 2 +- hw/sh4/r2d.c | 2 +-

[Qemu-devel] [PATCH 16/30] hw/sh4: use the BYTE-based definitions

2018-02-14 Thread Philippe Mathieu-Daudé
It ease code review, unit is explicit. Signed-off-by: Philippe Mathieu-Daudé --- hw/block/tc58128.c | 2 +- hw/sh4/r2d.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/block/tc58128.c b/hw/block/tc58128.c index 1d9f7ee000..3e658d509f 100644 --- a/hw/block/tc58128