Re: [Qemu-devel] [PATCH 16/16] megasas: LSI Megaraid SAS emulation

2010-11-19 Thread Jes Sorensen
On 11/19/10 17:36, Alexander Graf wrote: > > On 19.11.2010, at 15:31, Jes Sorensen wrote: >> What I mean is for most other device types we allow to specify a list of >> wanted devices at the configure line, which is what I am suggesting we >> added support for for SCSI as well. > > Oh, you mean s

Re: [Qemu-devel] [PATCH 16/16] megasas: LSI Megaraid SAS emulation

2010-11-19 Thread Alexander Graf
On 19.11.2010, at 15:31, Jes Sorensen wrote: > On 11/19/10 15:06, Markus Armbruster wrote: >>> Only comment, as you are adding another SCSI driver, maybe it's time to >>> make the driver selection configurable, rather than hard coding the build? >> >> What do you mean by that? >> >> We hardcode

Re: [Qemu-devel] [PATCH 16/16] megasas: LSI Megaraid SAS emulation

2010-11-19 Thread Jes Sorensen
On 11/19/10 15:06, Markus Armbruster wrote: >> Only comment, as you are adding another SCSI driver, maybe it's time to >> make the driver selection configurable, rather than hard coding the build? > > What do you mean by that? > > We hardcode lsi53c895a in two places where we really mean "default

Re: [Qemu-devel] [PATCH 16/16] megasas: LSI Megaraid SAS emulation

2010-11-19 Thread Hannes Reinecke
On 11/19/2010 03:06 PM, Markus Armbruster wrote: > Jes Sorensen writes: > >> On 11/18/10 15:47, Hannes Reinecke wrote: >>> This patch adds an emulation for the LSI Megaraid SAS HBA. >>> >>> Signed-off-by: Hannes Reinecke >>> --- >>> Makefile.objs |2 +- >>> hw/megasas.c | 1826 >>> +++

Re: [Qemu-devel] [PATCH 16/16] megasas: LSI Megaraid SAS emulation

2010-11-19 Thread Markus Armbruster
Jes Sorensen writes: > On 11/18/10 15:47, Hannes Reinecke wrote: >> This patch adds an emulation for the LSI Megaraid SAS HBA. >> >> Signed-off-by: Hannes Reinecke >> --- >> Makefile.objs |2 +- >> hw/megasas.c | 1826 >> + >> hw/mf

Re: [Qemu-devel] [PATCH 16/16] megasas: LSI Megaraid SAS emulation

2010-11-19 Thread Jes Sorensen
On 11/18/10 15:47, Hannes Reinecke wrote: > This patch adds an emulation for the LSI Megaraid SAS HBA. > > Signed-off-by: Hannes Reinecke > --- > Makefile.objs |2 +- > hw/megasas.c | 1826 > + > hw/mfi.h | 1197 +