-BEGIN PGP SIGNED MESSAGE-
Hash: SHA256
On 06/26/2015 12:11 PM, Stefan Hajnoczi wrote:
> On Mon, Jun 22, 2015 at 08:21:15PM -0400, John Snow wrote:
>> @@ -682,19 +680,22 @@ static void ahci_write_fis_sdb(AHCIState
>> *s, int port, uint32_t finished)
>>
>> sdb_fis->type = SATA_FIS_TYPE_S
On Mon, Jun 22, 2015 at 08:21:15PM -0400, John Snow wrote:
> @@ -682,19 +680,22 @@ static void ahci_write_fis_sdb(AHCIState *s, int port,
> uint32_t finished)
>
> sdb_fis->type = SATA_FIS_TYPE_SDB;
> /* Interrupt pending & Notification bit */
> -sdb_fis->flags = (ad->hba->control_r
There are two things to fix here:
The first one is subtle: the PxSACT register in the AHCI HBA has different
semantics from the field it is shadowing, the ACT field in the
Set Device Bits FIS.
In the HBA register, PxSACT acts as a bitfield indicating outstanding
NCQ commands where a set bit indic
