Re: [Qemu-devel] [PATCH 15/54] chardev: qom-ify

2017-01-05 Thread Marc-André Lureau
Hi - Original Message - > On 12/12/2016 04:42 PM, Marc-André Lureau wrote: > > Turn Chardev into Object. > > > > qemu_chr_alloc() is replaced by the qemu_chardev_new() constructor. It > > will call qemu_char_open() to open/intialize the chardev with the > > ChardevCommon *backend settings

Re: [Qemu-devel] [PATCH 15/54] chardev: qom-ify

2017-01-05 Thread Eric Blake
On 12/12/2016 04:42 PM, Marc-André Lureau wrote: > Turn Chardev into Object. > > qemu_chr_alloc() is replaced by the qemu_chardev_new() constructor. It > will call qemu_char_open() to open/intialize the chardev with the > ChardevCommon *backend settings. Review part 2: > spice-qemu-char.c |

Re: [Qemu-devel] [PATCH 15/54] chardev: qom-ify

2017-01-04 Thread Eric Blake
On 12/12/2016 04:42 PM, Marc-André Lureau wrote: > Turn Chardev into Object. > > qemu_chr_alloc() is replaced by the qemu_chardev_new() constructor. It > will call qemu_char_open() to open/intialize the chardev with the > ChardevCommon *backend settings. > > The CharDriver::create() callback is t

[Qemu-devel] [PATCH 15/54] chardev: qom-ify

2016-12-12 Thread Marc-André Lureau
Turn Chardev into Object. qemu_chr_alloc() is replaced by the qemu_chardev_new() constructor. It will call qemu_char_open() to open/intialize the chardev with the ChardevCommon *backend settings. The CharDriver::create() callback is turned into a ChardevClass::open() which is called from the newl