Re: [Qemu-devel] [PATCH 15/31] target-i386: use memory API to implement SMRAM

2015-06-01 Thread Michael S. Tsirkin
On Mon, Jun 01, 2015 at 10:58:57AM +0200, Paolo Bonzini wrote: > > > On 01/06/2015 10:10, Michael S. Tsirkin wrote: > > > UNUSED is written as zeroes, so it will think SMM is _disabled_, > > > unconditionally. Note that d->smram_region is backwards: it aliases to > > > VRAM, so it is enabled whe

Re: [Qemu-devel] [PATCH 15/31] target-i386: use memory API to implement SMRAM

2015-06-01 Thread Paolo Bonzini
On 01/06/2015 10:10, Michael S. Tsirkin wrote: > > UNUSED is written as zeroes, so it will think SMM is _disabled_, > > unconditionally. Note that d->smram_region is backwards: it aliases to > > VRAM, so it is enabled when SMRAM is closed and disabled when SMRAM is open. > > > > This is correct

Re: [Qemu-devel] [PATCH 15/31] target-i386: use memory API to implement SMRAM

2015-06-01 Thread Michael S. Tsirkin
On Mon, Jun 01, 2015 at 09:30:38AM +0200, Paolo Bonzini wrote: > > > On 31/05/2015 20:09, Michael S. Tsirkin wrote: > > On Mon, May 11, 2015 at 03:49:01PM +0200, Paolo Bonzini wrote: > >> Remove cpu_smm_register and cpu_smm_update. Instead, each CPU > >> address space gets an extra region which

Re: [Qemu-devel] [PATCH 15/31] target-i386: use memory API to implement SMRAM

2015-06-01 Thread Paolo Bonzini
On 31/05/2015 20:09, Michael S. Tsirkin wrote: > On Mon, May 11, 2015 at 03:49:01PM +0200, Paolo Bonzini wrote: >> Remove cpu_smm_register and cpu_smm_update. Instead, each CPU >> address space gets an extra region which is an alias of >> /machine/smram. This extra region is enabled or disabled

Re: [Qemu-devel] [PATCH 15/31] target-i386: use memory API to implement SMRAM

2015-05-31 Thread Michael S. Tsirkin
On Mon, May 11, 2015 at 03:49:01PM +0200, Paolo Bonzini wrote: > Remove cpu_smm_register and cpu_smm_update. Instead, each CPU > address space gets an extra region which is an alias of > /machine/smram. This extra region is enabled or disabled > as the CPU enters/exits SMM. > > Signed-off-by: Pa

[Qemu-devel] [PATCH 15/31] target-i386: use memory API to implement SMRAM

2015-05-11 Thread Paolo Bonzini
Remove cpu_smm_register and cpu_smm_update. Instead, each CPU address space gets an extra region which is an alias of /machine/smram. This extra region is enabled or disabled as the CPU enters/exits SMM. Signed-off-by: Paolo Bonzini --- bsd-user/main.c | 4 hw/i386/pc.c