Re: [Qemu-devel] [PATCH 15/22] machine: make max_cpus a -machine option

2010-06-09 Thread Jes Sorensen
On 06/08/10 01:52, Anthony Liguori wrote: > max_cpus is a weird property today. On the one hand, it represents the > maximum > CPUs a board can support and is used to validate the number of vcpus requested > by the user. > > On the other hand, max_cpus can be set by the user in which case it is

Re: [Qemu-devel] [PATCH 15/22] machine: make max_cpus a -machine option

2010-06-09 Thread Jes Sorensen
On 06/08/10 03:56, Anthony Liguori wrote: > On 06/07/2010 08:01 PM, Paul Brook wrote: >>> diff --git a/hw/realview.c b/hw/realview.c >>> index a36bdbe..8dcef80 100644 >>> --- a/hw/realview.c >>> +++ b/hw/realview.c >>> @@ -444,9 +444,9 @@ static QEMUMachine realview_eb_mpcore_machine = { >>>

Re: [Qemu-devel] [PATCH 15/22] machine: make max_cpus a -machine option

2010-06-07 Thread Paul Brook
> max_cpus is complicated because it was used for multiple purposes. I don't see any such uses. > > This is a fundamental property/limitation of the hardware. Expect qemu to > > crash if the value is modified. > > In this case, the machine cores should be rejecting totally invalid > values to pr

Re: [Qemu-devel] [PATCH 15/22] machine: make max_cpus a -machine option

2010-06-07 Thread Anthony Liguori
On 06/07/2010 08:01 PM, Paul Brook wrote: diff --git a/hw/realview.c b/hw/realview.c index a36bdbe..8dcef80 100644 --- a/hw/realview.c +++ b/hw/realview.c @@ -444,9 +444,9 @@ static QEMUMachine realview_eb_mpcore_machine = { .init = realview_eb_mpcore_init, .opts_default = (QemuOptVal

Re: [Qemu-devel] [PATCH 15/22] machine: make max_cpus a -machine option

2010-06-07 Thread Paul Brook
> diff --git a/hw/realview.c b/hw/realview.c > index a36bdbe..8dcef80 100644 > --- a/hw/realview.c > +++ b/hw/realview.c > @@ -444,9 +444,9 @@ static QEMUMachine realview_eb_mpcore_machine = { > .init = realview_eb_mpcore_init, > .opts_default = (QemuOptValue[]) { > QOPT_VALUE("d

[Qemu-devel] [PATCH 15/22] machine: make max_cpus a -machine option

2010-06-07 Thread Anthony Liguori
max_cpus is a weird property today. On the one hand, it represents the maximum CPUs a board can support and is used to validate the number of vcpus requested by the user. On the other hand, max_cpus can be set by the user in which case it is taken to mean the number of physical sockets that shoul