This is not a full QAPI conversion, but an intermediate step.
In essence, do_netdev_add() is split into three functions:
1. netdev_add(): performs the actual work. This function is fully
converted to Error (thus, it's "qapi-friendly")
2. qmp_netdev_add(): the QMP front-end for netdev_add()
Il 18/05/2012 19:41, Luiz Capitulino ha scritto:
> Other than that I think we should have a better separation between front-ends
> and back-ends in that code (we seem to call everything a "type").
That makes sense if you consider the way -net originally worked with
VLANs...
Paolo
On Fri, 18 May 2012 17:51:01 +0200
Laszlo Ersek wrote:
> > +void hmp_netdev_add(Monitor *mon, const QDict *qdict)
> > +{
> > +Error *err = NULL;
> > +QemuOpts *opts;
> > +
> > +opts = qemu_opts_from_qdict(qemu_find_opts("netdev"), qdict, &err);
>
> I note we trust qemu_find_opts("net
Comments in-line.
On 05/17/12 16:33, Luiz Capitulino wrote:
> This is not a full QAPI conversion, but an intermediate step.
>
> In essence, do_netdev_add() is split into three functions:
>
> 1. netdev_add(): performs the actual work. This function is fully
> converted to Error (thus, it's "
This is not a full QAPI conversion, but an intermediate step.
In essence, do_netdev_add() is split into three functions:
1. netdev_add(): performs the actual work. This function is fully
converted to Error (thus, it's "qapi-friendly")
2. qmp_netdev_add(): the QMP front-end for netdev_add()
This is not a full QAPI conversion, but an intermediate step.
In essence, do_netdev_add() is split into three functions:
1. netdev_add(): performs the actual work. This function is fully
converted to Error (thus, it's "qapi-friendly")
2. qmp_netdev_add(): the QMP front-end for netdev_add()
This is not a full QAPI conversion, but an intermediate step.
In essence, do_netdev_add() is split into three functions:
1. netdev_add(): performs the actual work. This function is fully
converted to Error (thus, it's "qapi-friendly")
2. qmp_netdev_add(): the QMP front-end for netdev_add()
