Re: [Qemu-devel] [PATCH 14/22] usb: Add packet combining functions

2012-10-17 Thread Gerd Hoffmann
Hi, > For handle_combined_data, yes, as usb_ep_combine_input_packets can > cause multiple packets to get submitted, since if a combined packet > ends with a packet, which does not have its short_not_ok flag set, > another packet can be safely pipelined after it. This is not > useful for usb mass

Re: [Qemu-devel] [PATCH 14/22] usb: Add packet combining functions

2012-10-17 Thread Hans de Goede
Hi, On 10/17/2012 01:29 PM, Gerd Hoffmann wrote: Hi, +/* + * Process / cancel combined packets, called from + * usb_ep_combine_input_packets() / usb_combined_packet_cancel(). + * Only called for devices which call these functions themselves. + */ +int (*handle_combin

Re: [Qemu-devel] [PATCH 14/22] usb: Add packet combining functions

2012-10-17 Thread Gerd Hoffmann
Hi, > +/* > + * Process / cancel combined packets, called from > + * usb_ep_combine_input_packets() / usb_combined_packet_cancel(). > + * Only called for devices which call these functions themselves. > + */ > +int (*handle_combined_data)(USBDevice *dev, USBPacket *p); >

[Qemu-devel] [PATCH 14/22] usb: Add packet combining functions

2012-10-15 Thread Hans de Goede
Currently we only do pipelining for output endpoints, since to properly support short-not-ok semantics we can only have one outstanding input packet. Since the ehci and uhci controllers have a limited per td packet size guests will split large input transfers to into multiple packets, and since we