Re: [Qemu-devel] [PATCH 14/15] acpi: Add hooks for adding things to the SSDT table

2015-04-13 Thread Paolo Bonzini
On 13/04/2015 18:00, Corey Minyard wrote: > On 04/13/2015 08:44 AM, Paolo Bonzini wrote: >> >> On 13/04/2015 03:30, Corey Minyard wrote: Hmm, I don't see patch 15/15 so I don't know how this is used. >>> Yeah, I resent and I don't know what's happened. All the others were >>> sent exactly t

Re: [Qemu-devel] [PATCH 14/15] acpi: Add hooks for adding things to the SSDT table

2015-04-13 Thread Corey Minyard
On 04/13/2015 08:44 AM, Paolo Bonzini wrote: > > On 13/04/2015 03:30, Corey Minyard wrote: >>> Hmm, I don't see patch 15/15 so I don't know how this is used. >> Yeah, I resent and I don't know what's happened. All the others were >> sent exactly the same way. Something doesn't like that patch. >

Re: [Qemu-devel] [PATCH 14/15] acpi: Add hooks for adding things to the SSDT table

2015-04-13 Thread Paolo Bonzini
On 13/04/2015 13:32, Michael S. Tsirkin wrote: So you are suggesting each device add it's own SSDT? I'm not sure how that helps debugging, it seems simpler to add it to a common one. >>> >>> For example, it's easier to write a unit test: encode something specific >>> in one of the IDs

Re: [Qemu-devel] [PATCH 14/15] acpi: Add hooks for adding things to the SSDT table

2015-04-13 Thread Paolo Bonzini
On 13/04/2015 03:30, Corey Minyard wrote: > > Hmm, I don't see patch 15/15 so I don't know how this is used. > > Yeah, I resent and I don't know what's happened. All the others were > sent exactly the same way. Something doesn't like that patch. Can you send that privately? Or put it somewhe

Re: [Qemu-devel] [PATCH 14/15] acpi: Add hooks for adding things to the SSDT table

2015-04-13 Thread Michael S. Tsirkin
On Mon, Apr 13, 2015 at 10:39:39AM +0200, Paolo Bonzini wrote: > > > On 13/04/2015 08:36, Michael S. Tsirkin wrote: > >> > So you are suggesting each device add it's own SSDT? I'm not sure how > >> > that helps debugging, it seems simpler to add it to a common one. > > For example, it's easier t

Re: [Qemu-devel] [PATCH 14/15] acpi: Add hooks for adding things to the SSDT table

2015-04-13 Thread Paolo Bonzini
On 13/04/2015 08:36, Michael S. Tsirkin wrote: >> > So you are suggesting each device add it's own SSDT? I'm not sure how >> > that helps debugging, it seems simpler to add it to a common one. > For example, it's easier to write a unit test: encode something specific > in one of the IDs, then lo

Re: [Qemu-devel] [PATCH 14/15] acpi: Add hooks for adding things to the SSDT table

2015-04-12 Thread Michael S. Tsirkin
On Sun, Apr 12, 2015 at 08:30:45PM -0500, Corey Minyard wrote: > On 04/12/2015 11:17 AM, Michael S. Tsirkin wrote: > > On Tue, Apr 07, 2015 at 02:51:43PM -0500, miny...@acm.org wrote: > >> From: Corey Minyard > >> > >> This way devices can tie in when then SSDT is built and can add their > >> own

Re: [Qemu-devel] [PATCH 14/15] acpi: Add hooks for adding things to the SSDT table

2015-04-12 Thread Corey Minyard
On 04/12/2015 11:17 AM, Michael S. Tsirkin wrote: > On Tue, Apr 07, 2015 at 02:51:43PM -0500, miny...@acm.org wrote: >> From: Corey Minyard >> >> This way devices can tie in when then SSDT is built and can add their >> own entries. This didn't seem to fit anyplace else, primarily because it >> re

Re: [Qemu-devel] [PATCH 14/15] acpi: Add hooks for adding things to the SSDT table

2015-04-12 Thread Michael S. Tsirkin
On Tue, Apr 07, 2015 at 02:51:43PM -0500, miny...@acm.org wrote: > From: Corey Minyard > > This way devices can tie in when then SSDT is built and can add their > own entries. This didn't seem to fit anyplace else, primarily because it > required the Aml type, so I added a new file for it. > >

[Qemu-devel] [PATCH 14/15] acpi: Add hooks for adding things to the SSDT table

2015-04-07 Thread minyard
From: Corey Minyard This way devices can tie in when then SSDT is built and can add their own entries. This didn't seem to fit anyplace else, primarily because it required the Aml type, so I added a new file for it. Signed-off-by: Corey Minyard --- hw/acpi/Makefile.objs| 1 + hw/acpi