Re: [Qemu-devel] [PATCH 12/54] spice-char: improve error reporting

2017-01-05 Thread Marc-André Lureau
Hi On Wed, Jan 4, 2017 at 11:00 PM Eric Blake wrote: > On 12/12/2016 04:42 PM, Marc-André Lureau wrote: > > Set errp to report errors up. > > > > Use error_report() to give hints about parameters on the right monitor, > > instead of a direct fprintf() call. > > > > Signed-off-by: Marc-André Lure

Re: [Qemu-devel] [PATCH 12/54] spice-char: improve error reporting

2017-01-04 Thread Eric Blake
On 12/12/2016 04:42 PM, Marc-André Lureau wrote: > Set errp to report errors up. > > Use error_report() to give hints about parameters on the right monitor, > instead of a direct fprintf() call. > > Signed-off-by: Marc-André Lureau > --- > spice-qemu-char.c | 29 + >

[Qemu-devel] [PATCH 12/54] spice-char: improve error reporting

2016-12-12 Thread Marc-André Lureau
Set errp to report errors up. Use error_report() to give hints about parameters on the right monitor, instead of a direct fprintf() call. Signed-off-by: Marc-André Lureau --- spice-qemu-char.c | 29 + 1 file changed, 9 insertions(+), 20 deletions(-) diff --git a/spi