Re: [Qemu-devel] [PATCH 12/16] vga: Convert to isa_register_portio_list.

2011-09-18 Thread Avi Kivity
On 09/18/2011 06:15 PM, Richard Henderson wrote: On 09/18/2011 07:56 AM, Avi Kivity wrote: > It's also wrong for cirrus. Even though it is a legacy address, it's > not an ISA address, it's on the PCI bus (though not mapped by a BAR). Huh? How do define that as not an ISA address? Especially

Re: [Qemu-devel] [PATCH 12/16] vga: Convert to isa_register_portio_list.

2011-09-18 Thread Richard Henderson
On 09/18/2011 07:56 AM, Avi Kivity wrote: > It's also wrong for cirrus. Even though it is a legacy address, it's > not an ISA address, it's on the PCI bus (though not mapped by a BAR). Huh? How do define that as not an ISA address? Especially since all that's called from isa_cirrus_vga_init? r

Re: [Qemu-devel] [PATCH 12/16] vga: Convert to isa_register_portio_list.

2011-09-18 Thread Avi Kivity
On 09/18/2011 05:27 PM, Avi Kivity wrote: On 09/18/2011 05:16 PM, Richard Henderson wrote: On 09/18/2011 06:45 AM, Avi Kivity wrote: >> +/* The PCI-ISA bridge should have been configured properly such that >> + this works for PCI devices as well. This only supports one bridge, >>

Re: [Qemu-devel] [PATCH 12/16] vga: Convert to isa_register_portio_list.

2011-09-18 Thread Avi Kivity
On 09/18/2011 05:16 PM, Richard Henderson wrote: On 09/18/2011 06:45 AM, Avi Kivity wrote: >> +/* The PCI-ISA bridge should have been configured properly such that >> + this works for PCI devices as well. This only supports one bridge, >> + but "secondary" VGA cards are genera

Re: [Qemu-devel] [PATCH 12/16] vga: Convert to isa_register_portio_list.

2011-09-18 Thread Richard Henderson
On 09/18/2011 06:45 AM, Avi Kivity wrote: >> +/* The PCI-ISA bridge should have been configured properly such that >> + this works for PCI devices as well. This only supports one bridge, >> + but "secondary" VGA cards are generally accessed by MMIO only >> anyway. */ >> +isa_

Re: [Qemu-devel] [PATCH 12/16] vga: Convert to isa_register_portio_list.

2011-09-18 Thread Avi Kivity
On 08/24/2011 03:13 AM, Richard Henderson wrote: Signed-off-by: Richard Henderson Breaks qemu-system-ppc -M mac99 +/* Used by both ISA and PCI */ MemoryRegion *vga_init_io(VGACommonState *s) { MemoryRegion *vga_mem; -register_ioport_write(0x3c0, 16, 1, vga_ioport_write, s); - -

[Qemu-devel] [PATCH 12/16] vga: Convert to isa_register_portio_list.

2011-08-23 Thread Richard Henderson
Signed-off-by: Richard Henderson --- hw/vga-isa.c | 10 -- hw/vga.c | 55 --- 2 files changed, 28 insertions(+), 37 deletions(-) diff --git a/hw/vga-isa.c b/hw/vga-isa.c index 0d19901..510ace8 100644 --- a/hw/vga-isa.c +++ b/hw/